[SVS] Add support for GLIBC 2.26 systems and GCC v11.2. E.g. AmazonLinux 2 #720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR broadens Linux compatibility to GLIBC ≥2.26 (e.g., AmazonLinux 2) and adds a GCC 11.2 workaround by:
- Replacing invalid
view()calls in tests withstr(). - Extending CMake to detect GLIBC 2.26 and 2.28 and select appropriate SVS shared-library URLs or disable the build.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/unit/test_svs.cpp | Swapped .view() for .str() on ostringstream to fetch logs. |
| cmake/svs.cmake | Added checks for GLIBC 2.26/2.28 and conditional SVS_SHARED_LIB configuration. |
meiravgri
reviewed
Jul 2, 2025
| if (GLIBC_2_28_FOUND) | ||
| set(SVS_URL "https://github.com/intel/ScalableVectorSearch/releases/download/v0.0.8-dev/svs-shared-library-0.0.8-NIGHTLY-20250630.tar.gz" CACHE STRING "SVS URL") | ||
| elseif(GLIBC_2_26_FOUND) | ||
| set(SVS_URL "https://github.com/intel/ScalableVectorSearch/releases/download/v0.0.8-dev/svs-shared-library-0.0.8-NIGHTLY-20250701-glibc-2_26.tar.gz" CACHE STRING "SVS URL") |
Collaborator
There was a problem hiding this comment.
Is there any difference between the two binaries aside from the system they were built on?
Collaborator
Author
There was a problem hiding this comment.
@ethanglaser, can you please provide qualified answer to this question?
Thank you.
rfsaliev
force-pushed
the
rfsaliev/svs-glibc-2-26
branch
from
da49299 to
9e7f34c
Compare
meiravgri
approved these changes
Jul 2, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #720 +/- ##
=======================================
Coverage 96.86% 96.86%
=======================================
Files 122 122
Lines 7397 7397
=======================================
Hits 7165 7165
Misses 232 232 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 2, 2025
…nux 2 (#720) * [SVS] Add support for GLIBC 2.26 systems. E.g. AmazonLinux 2 * Workaround GCC v11.2 C++20 compatibility issue * fixup! [SVS] Add support for GLIBC 2.26 systems. E.g. AmazonLinux 2
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Successfully created backport PR for |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 3, 2025
…azonLinux 2 (#721) [SVS] Add support for GLIBC 2.26 systems and GCC v11.2. E.g. AmazonLinux 2 (#720) * [SVS] Add support for GLIBC 2.26 systems. E.g. AmazonLinux 2 * Workaround GCC v11.2 C++20 compatibility issue * fixup! [SVS] Add support for GLIBC 2.26 systems. E.g. AmazonLinux 2 (cherry picked from commit e1d0334) Co-authored-by: Rafik Saliev <rafik.f.saliev@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
This change includes compatibility issues for Linux OSes with GLIBC prior to v.2.28 including AmazonLinux 2.
Now the minimum supported GLIBC version is 2.26.
This change also includes the workaround for GCC v.11.2, which does not fully support C++20 standard.
Which issues this PR fixes
Main objects this PR modified
Mark if applicable