-
Notifications
You must be signed in to change notification settings - Fork 45
python 3.14 and UI in CI #295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis PR updates the CI pipelines to use Python 3.14 via the astral-sh/setup-uv wrapper, unifies pip invocations under uv, refreshes GitHub Action versions, extends the test matrix to cover Python 3.14 with Firefox, and bumps the project’s required Python version to ≥3.11. Class diagram for updated Python version requirement in pyproject.tomlclassDiagram
class ProjectMetadata {
+name: string
+readme: string
+requires-python: ">=3.11"
+dependencies: list
+classifiers: list
+maintainers: list
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- The platform job no longer depends on the main test job—consider re-adding tests as a prerequisite so you don’t run platform builds on unverified code.
- There’s a lot of repeated checkout/setup/install boilerplate across jobs; extracting those into a reusable workflow or composite action would reduce YAML duplication and maintenance overhead.
- You’re only running Firefox on Python 3.14—either expand Firefox tests to cover your other supported Python versions or update your compatibility policy to reflect Firefox being 3.14+ only.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The platform job no longer depends on the main test job—consider re-adding tests as a prerequisite so you don’t run platform builds on unverified code.
- There’s a lot of repeated checkout/setup/install boilerplate across jobs; extracting those into a reusable workflow or composite action would reduce YAML duplication and maintenance overhead.
- You’re only running Firefox on Python 3.14—either expand Firefox tests to cover your other supported Python versions or update your compatibility policy to reflect Firefox being 3.14+ only.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
8ab4aaf to
44907b7
Compare
19afe3e to
dd216dc
Compare
dd216dc to
11c07f2
Compare
|
After this I learn that replacing setup-python con't replace by setup-uv. |
Summary by Sourcery
Add Python 3.14 support and modernise CI workflows by switching to the UV installer for Python, updating action versions, and refining the test matrix.
New Features:
Enhancements:
CI: