Skip to content

Conversation

@digitronik
Copy link
Member

@digitronik digitronik commented Nov 14, 2025

Summary by Sourcery

Add Python 3.14 support and modernise CI workflows by switching to the UV installer for Python, updating action versions, and refining the test matrix.

New Features:

  • Add support for Python 3.14 across the project and CI pipelines

Enhancements:

  • Raise minimum Python requirement to >=3.11 and add Python 3.14 classifier in pyproject.toml

CI:

  • Use astral-sh/setup-uv@v7 for Python setup and prefix all pip commands with 'uv'
  • Upgrade GitHub Actions steps to v5 for checkout, codecov, and upload-artifact
  • Expand CI matrix to include Python 3.14, run Firefox tests only on 3.14, and disable fail-fast

@sourcery-ai
Copy link

sourcery-ai bot commented Nov 14, 2025

Reviewer's Guide

This PR updates the CI pipelines to use Python 3.14 via the astral-sh/setup-uv wrapper, unifies pip invocations under uv, refreshes GitHub Action versions, extends the test matrix to cover Python 3.14 with Firefox, and bumps the project’s required Python version to ≥3.11.

Class diagram for updated Python version requirement in pyproject.toml

classDiagram
  class ProjectMetadata {
    +name: string
    +readme: string
    +requires-python: ">=3.11"
    +dependencies: list
    +classifiers: list
    +maintainers: list
  }
Loading

File-Level Changes

Change Details Files
Adopt uv pip wrapper and Python 3.14 across CI
  • Switch setup-python@v5 to astral-sh/setup-uv@v7 and prefix all pip calls with "uv pip --system"
  • Update python-version to "3.14" in setup steps for tests, docs, platform, and package jobs
  • Unify dependency installation commands (tests, docs, package build) under uv pip
.github/workflows/test_suite.yml
Refresh GitHub Action versions and CI behavior
  • Bump actions/checkout, actions/cache, codecov/codecov-action to v5 where applicable
  • Add fail-fast: false to the test matrix for more resilient runs
  • Limit default matrix to Chromium and include a Firefox run only on Python 3.14
.github/workflows/test_suite.yml
Update package metadata to require Python ≥3.11 and support 3.14
  • Add Python :: 3.14 classifier to pyproject.toml
  • Raise requires-python from ">=3.10" to ">=3.11"
pyproject.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • The platform job no longer depends on the main test job—consider re-adding tests as a prerequisite so you don’t run platform builds on unverified code.
  • There’s a lot of repeated checkout/setup/install boilerplate across jobs; extracting those into a reusable workflow or composite action would reduce YAML duplication and maintenance overhead.
  • You’re only running Firefox on Python 3.14—either expand Firefox tests to cover your other supported Python versions or update your compatibility policy to reflect Firefox being 3.14+ only.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The platform job no longer depends on the main test job—consider re-adding tests as a prerequisite so you don’t run platform builds on unverified code.
- There’s a lot of repeated checkout/setup/install boilerplate across jobs; extracting those into a reusable workflow or composite action would reduce YAML duplication and maintenance overhead.
- You’re only running Firefox on Python 3.14—either expand Firefox tests to cover your other supported Python versions or update your compatibility policy to reflect Firefox being 3.14+ only.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@digitronik digitronik marked this pull request as draft November 14, 2025 10:16
@digitronik digitronik force-pushed the optimized_tests branch 2 times, most recently from 19afe3e to dd216dc Compare November 14, 2025 11:41
@digitronik
Copy link
Member Author

After this I learn that replacing setup-python con't replace by setup-uv.
installing python will slow down process.

@digitronik digitronik closed this Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant