Reorganize the tracking context #35
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacooobi
force-pushed
the
refactor-tracking-and-ingestion-modules
branch
6 times, most recently
from
83d16f2 to
79f08d0
Compare
jacooobi
force-pushed
the
refactor-tracking-and-ingestion-modules
branch
from
79f08d0 to
21a92d9
Compare
siepet
reviewed
Jan 20, 2026
| additional_params = parse_additional_params(params) | ||
| params = Map.merge(core_params, additional_params) | ||
|
|
||
| ua = parse_user_agent(conn) |
siepet
reviewed
Jan 20, 2026
| end) | ||
| end | ||
|
|
||
| defp build_event_attrs(params, ua, uri, host, query, ref, location_details) do |
There was a problem hiding this comment.
Maybe build a type out of this and extract to separate module as a struct?
siepet
reviewed
Jan 20, 2026
| @@ -0,0 +1,80 @@ | |||
| defmodule Plausible.Test.EventHelpers do | |||
There was a problem hiding this comment.
plausible_event_helpers maybe to indicate the scope of the file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.