Skip to content

Conversation

@CdeJong
Copy link

@CdeJong CdeJong commented Aug 29, 2023

fixes #107

@PinoOG
Copy link

PinoOG commented Dec 6, 2023

fixes #107

Minimum bet system is not working, users are being able to bet minor than minimum-bet

@CdeJong
Copy link
Author

CdeJong commented Dec 7, 2023

Hello, could you maybe tell in what way the system isn't working for you? What commands are you using? Are you sure you wrote the config paths correctly?

request:
  money-betting:
    minimum-bet-amount: 0.001
    maximum-bet-amount: 10000000000

@broken1arrow
Copy link

fixes #107

double only partially fix the problem. Best is to use bigInteger or bigDecimals. Depending on you need decimals or not.

@CdeJong
Copy link
Author

CdeJong commented Aug 3, 2024

This is true, fully changing everything to BigDecimals would be the best solution. Main issue is that vault still uses doubles for al its methods. Which is still being used in most servers, which would mean that this plugin would still need to respect the limitations of doubles.

@broken1arrow
Copy link

This is true, fully changing everything to BigDecimals would be the best solution. Main issue is that vault still uses doubles for al its methods. Which is still being used in most servers, which would mean that this plugin would still need to respect the limitations of doubles.

In that case could you convert to double with correct pression. But yeah vault really need a update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integer overflow when wager gets payed out

3 participants