fix: resolve lint errors and fix infinite loop in NewSkillsDialog#15
Merged
fix: resolve lint errors and fix infinite loop in NewSkillsDialog#15
Conversation
- Fix same infinite re-render loop in NewSkillsDialog as InstallDialog (useEffect with unstable detectedAgents dependency when single agent) - Fix React hook ordering in CliSections (hooks called after early return) - Add missing kindMap dependency to useMemo in audit page - Remove unused extensions variable from ExtensionFilters - Replace catch (e: any) with catch (e: unknown) for type safety - Remove unnecessary Fragment wrapper and non-null assertions - Fix assignment-in-expression lint warning in onboarding - Apply biome auto-formatting across codebase Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NewSkillsDialogas fix: prevent infinite re-render loop in InstallDialog #13 fixed inInstallDialog(single detected agent triggers infinite loop)Changes
new-skills-dialog.tsxdetail-cli-sections.tsxkindMapuseMemo dependencyaudit.tsxextension-filters.tsxcatch (e: any)→catch (e: unknown)detail-header.tsx,new-skills-dialog.tsx,extension-store.ts!/<>wrapperdelete-dialog.tsx,detail-cli-sections.tsxonboarding.tsxTest plan
🤖 Generated with Claude Code