Skip to content

fix: update remaining code for flattened CLI children#14

Merged
RealZST merged 4 commits intomainfrom
fix/flatten-cli-followup
Apr 13, 2026
Merged

fix: update remaining code for flattened CLI children#14
RealZST merged 4 commits intomainfrom
fix/flatten-cli-followup

Conversation

@RealZST
Copy link
Copy Markdown
Owner

@RealZST RealZST commented Apr 13, 2026

Summary

Follow-up to #12 — fixes all remaining code that treated CLI children as hidden/nested after flattening.

Counts & Filters

  • Remove cli_parent_id filters in overview activity, agent extension counts, and CLI status command
  • Stale pack filter auto-clears when pack no longer exists

Audit

  • Each extension gets its own audit entry (remove child→parent merging in groupKeyMap and parentIdMap)
  • "View Extension" navigates via groupKey for precise targeting (no longer lands on CLI parent for same-named children)
  • Hook names display in friendly format matching Extensions page

Backend

  • CLI toggle no longer cascades to children server-side (frontend handles cascade)
  • Audit rules no longer skip CLI children — all extensions audited independently
  • Remove child_permissions aggregation in audit service

Table

  • Default sort set to name ascending (was unsorted)

Test plan

  • Run audit → verify each extension has its own audit result and trust score
  • Verify audit count numbers match (N scanned = N results)
  • Click "View Extension" on a CLI child skill in audit → verify it opens the correct detail panel
  • Check overview activity → verify CLI child skills appear
  • Check agent detail page → verify extension counts include CLI children
  • Toggle CLI parent → verify children still cascade (frontend-driven)
  • Verify hook names in audit match Extensions page format
  • Restart app → verify default sort is by name A-Z

🤖 Generated with Claude Code

RealZST and others added 4 commits April 13, 2026 23:04
Remove cli_parent_id filters that hid child skills from counts and
lists. CLI children are now independent extensions — they should appear
in all stats, audit results, and activity feeds.

- overview.tsx: remove cli_parent_id skip in activity list
- agents.rs: include CLI children in agent extension counts
- main.rs (CLI): include CLI children in status and list commands
- manager.rs: CLI toggle no longer cascades to children (frontend handles it)
- auditor/rules.rs: audit CLI children independently (remove all skips)
- service.rs: remove child_permissions aggregation for CLI audit
- Update tests to verify CLI children are audited

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Remove parentIdMap that merged child skill findings into CLI parent.
Each extension now has its own audit entry, fixing the 139/138 count
mismatch.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Remove groupKeyMap child→parent key override so each extension has
  its own audit entry (fixes 139/138 count mismatch)
- View Extension navigates via groupKey for precise targeting
- Extensions page supports groupKey query param
- Default table sorting set to name ascending (was empty/unsorted)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Apply the same hook name formatting as the Extensions page: strip
event prefix and directory paths (e.g., "afplay Glass.aiff" instead
of "AfterAgent:*:afplay /System/Library/Sounds/Glass.aiff").

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@RealZST RealZST merged commit 2043900 into main Apr 13, 2026
3 checks passed
@RealZST RealZST deleted the fix/flatten-cli-followup branch April 13, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant