fix: update remaining code for flattened CLI children#14
Merged
Conversation
Remove cli_parent_id filters that hid child skills from counts and lists. CLI children are now independent extensions — they should appear in all stats, audit results, and activity feeds. - overview.tsx: remove cli_parent_id skip in activity list - agents.rs: include CLI children in agent extension counts - main.rs (CLI): include CLI children in status and list commands - manager.rs: CLI toggle no longer cascades to children (frontend handles it) - auditor/rules.rs: audit CLI children independently (remove all skips) - service.rs: remove child_permissions aggregation for CLI audit - Update tests to verify CLI children are audited Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Remove parentIdMap that merged child skill findings into CLI parent. Each extension now has its own audit entry, fixing the 139/138 count mismatch. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Remove groupKeyMap child→parent key override so each extension has its own audit entry (fixes 139/138 count mismatch) - View Extension navigates via groupKey for precise targeting - Extensions page supports groupKey query param - Default table sorting set to name ascending (was empty/unsorted) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Apply the same hook name formatting as the Extensions page: strip event prefix and directory paths (e.g., "afplay Glass.aiff" instead of "AfterAgent:*:afplay /System/Library/Sounds/Glass.aiff"). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #12 — fixes all remaining code that treated CLI children as hidden/nested after flattening.
Counts & Filters
cli_parent_idfilters in overview activity, agent extension counts, and CLI status commandAudit
Backend
Table
Test plan
🤖 Generated with Claude Code