test: implement comprehensive application feedback tests

[AnujChhikara]

Date: 18 Jan, 2026

Developer Name: @AnujChhikara

---

Issue Ticket Number

• Support Change Requests and Feedback Tracking in Application Flow #2554

Description

• Added integration tests for submitting application feedback with various statuses (accepted, rejected, changes_requested).
• Enhanced unit tests for the application feedback submission logic, covering success and error scenarios.
• Updated application validator tests to ensure proper validation of feedback requirements based on status.
• Included tests for handling empty feedback strings and ensuring feedback is appended correctly to existing records.

Documentation Updated?

• Yes
• No

Under Feature Flag

• Yes
• No

Database Changes

• Yes
• No

Breaking Changes

• Yes
• No

Development Tested?

• Yes
• No

Test Coverage

Screenshot 1

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

This PR adds comprehensive test coverage for a new application feedback submission feature, including integration tests for the PATCH endpoint, unit tests for the controller and model methods, and expanded validator tests for status and feedback handling.

Changes

Cohort / File(s)	Summary
Integration Tests test/integration/application.test.ts	Adds 178 lines of integration tests for PATCH /applications/:applicationId/feedback covering successful submissions (rejected, changes_requested with/without feedback, accepted), validation errors (400 for changes_requested without feedback), and authorization/existence checks (401 for unauthorized/non-super user, 404 for missing application).
Unit Tests - Controller test/unit/controllers/applications.test.ts	Consolidates nudgeApplication stub usage across tests (+138/-8) and introduces new submitApplicationFeedback test suite validating successful submissions, optional feedback handling, and error cases (notFound, badImplementation).
Unit Tests - Validator test/unit/middlewares/application-validator.test.ts	Refactors to ES modules and shared test scaffolding (+118/-49); expands validateApplicationUpdateData tests for status values with/without optional feedback; adds validateApplicationQueryParam test coverage for allowed and disallowed query params.
Unit Tests - Model test/unit/models/application.test.ts	Introduces comprehensive addApplicationFeedback test suite (+188 lines) validating success paths for all statuses, feedback text trimming, multiple feedback entries, notFound handling, and createdAt timestamp inclusion.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• feat: add application feedback submission functionality #2552: Directly related as tests target the new submitApplicationFeedback handler, PATCH route, and validator behavior introduced in that PR.
• feat: Implement Create Application Flow for User Onboarding #2534: Related through added tests for submitApplicationFeedback and changes_requested status validation.
• feat: add nudge application functionality #2542: Related through shared nudgeApplicationStub refactoring and feedback-related test expansion.

Suggested reviewers

• Hariom01010
• iamitprakash

Poem

🐰 Tests bloom like carrots in the spring so bright,
Feedback flows through systems, checked left and right,
Integration, unit, validator stacks aligned,
Every status, edge case, carefully designed,
Quality assured with each assertion's might! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely summarizes the main change: implementing comprehensive application feedback tests across integration and unit tests.
Description check	✅ Passed	The description is well-related to the changeset, detailing the specific tests added for application feedback submission, validation, and error scenarios.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

The base branch was changed.

[coderabbitai]

Actionable comments posted: 2

🤖 Fix all issues with AI agents

In `@test/integration/application.test.ts`:
- Around line 597-615: Remove the duplicate "should return 401 if user is not a
super user" test block in test/integration/application.test.ts (the one that
calls .patch(`/applications/${applicationId1}/feedback`) and uses
cookieName/jwt) so only the original test remains; locate the duplicate by the
test description string and delete that entire it(...) block to avoid redundant
coverage while leaving the earlier identical test (the original at the other
location) intact.

In `@test/unit/middlewares/application-validator.test.ts`:
- Around line 2-3: Remove the unnecessary alias by deleting the `const Sinon =
sinon;` declaration and use the imported `sinon` object directly; update all
occurrences of `Sinon.spy()` (and any other `Sinon.*` usages) to `sinon.spy()`
(or corresponding `sinon.*`) so the tests use the original import consistently.