Skip to content

Conversation

@blizzardOfAce
Copy link
Contributor

Fixes: #1192

This PR improves the visibility of the "starred icon" in the article list.

What this PR changes

  • The icon now scales dynamically based on the current text size, so it respects user font scaling.
  • Color is updated to a higher-contrast onSurface with slight alpha.
Before After
Screenshot_1764093141 Screenshot_1764095334

Code changes:

@Composable
fun StarredIcon(modifier: Modifier = Modifier) {
+    val fontSize = LocalTextStyle.current.fontSize
+    val iconSize = with(LocalDensity.current) { fontSize.toDp() }

    Icon(
        modifier = modifier
-            .size(16.dp)
+            .size(iconSize) //  scales with font size
            .padding(end = 2.dp),
        imageVector = Icons.Rounded.Star,
        contentDescription = stringResource(R.string.starred),
-        tint = Color.Gray,
+        tint = MaterialTheme.colorScheme
+            .onSurface
+            .copy(alpha = 0.7f), //  better visibility (theme-adaptive)
    )
}


@Ashinch Ashinch self-requested a review November 26, 2025 03:15
Copy link
Member

@Ashinch Ashinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good.

@Ashinch Ashinch merged commit bd2c3fb into ReadYouApp:main Nov 26, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

in the article list, "starred" marker is badly visible

2 participants