fix(ui): improve starred icon visibility in articles list #1197
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1192
This PR improves the visibility of the "starred icon" in the article list.
What this PR changes
onSurfacewith slight alpha.Code changes:
@Composable fun StarredIcon(modifier: Modifier = Modifier) { + val fontSize = LocalTextStyle.current.fontSize + val iconSize = with(LocalDensity.current) { fontSize.toDp() } Icon( modifier = modifier - .size(16.dp) + .size(iconSize) // scales with font size .padding(end = 2.dp), imageVector = Icons.Rounded.Star, contentDescription = stringResource(R.string.starred), - tint = Color.Gray, + tint = MaterialTheme.colorScheme + .onSurface + .copy(alpha = 0.7f), // better visibility (theme-adaptive) ) }