Skip to content

Conversation

@JacksonBurns
Copy link
Contributor

Pair PR with ReactionMechanismGenerator/RMG-Py#2669

 - copy the download logic from RMG-Py (ReactionMechanismGenerator/RMG-Py#2669) that updates the version of download-artifact
 - increment setup-miniconda
@JacksonBurns
Copy link
Contributor Author

@rwest I tacked on a85e44c to fix the Conda build check when running from forks.

Copy link
Member

@rwest rwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The point of the conda_build change is so that the the workflow, on forks, does not fail (but it won't actually upload binaries), correct?
I can't tell that it'll work by reading the diff, but if it does what you intended, then this all looks fine to me.

@JacksonBurns
Copy link
Contributor Author

Yeah it just runs the build but does not publish it

@JacksonBurns JacksonBurns merged commit 86351e7 into ReactionMechanismGenerator:main Jun 7, 2024
@JacksonBurns JacksonBurns deleted the fix/ci_downloadv4 branch June 7, 2024 16:25
@jonwzheng
Copy link
Contributor

It looks like there's potentially something broken with this as CI is failing for new PRs:

Run actions/download-artifact@v4
Downloading single artifact
Error: Unable to download artifact(s): Artifact not found for name: stable_regression_results
        Please ensure that your artifact is not expired and the artifact was uploaded using a compatible version of toolkit/upload-artifact.
        For more information, visit the GitHub Artifacts FAQ: https://github.com/actions/toolkit/blob/main/packages/artifact/docs/faq.md

@JacksonBurns
Copy link
Contributor Author

The name of the GitHub actions token was being passed incorrectly, I copied the fix in from the RMG-Py PR which fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants