Skip to content

Conversation

@kspieks
Copy link
Contributor

@kspieks kspieks commented Mar 28, 2022

Previously, #565 added 1D rotor scans on the reactants and products to improve the estimations from the thermo library. Scans were also done on the TS to improve A-factors for the training reactions used to fit the rate trees. However, when using ATG, this previous PR used the following set of thermo libraries: thermo_libraries = ['Spiekermann_refining_elementary_reactions', 'primaryThermoLibrary']. However, our convention should be to use

thermo_libraries = [
                'Klippenstein_Glarborg2016', 'BurkeH2O2', 'thermo_DFT_CCSDTF12_BAC', 'DFT_QCI_thermo',
                'primaryThermoLibrary', 'primaryNS', 'NitrogenCurran', 'NOx2018', 'FFCM1(-)',
                'SulfurLibrary', 'SulfurGlarborgH2S', 'SABIC_aromatics',
            ],

and then append my thermo library to the front. This is the same list in our ATG notebook as well as our ATG script.

Thus, this PR refits the rate rules using the updated list of thermo libraries, which is especially important since family is its own reverse. When looking at rules.py, it appears there are many changes to the tree. However, the mean and median error are basically identical to what was calculated before. This can be see by looking at the last few cells in the old and new notebooks attached below. It makes sense that the mean and medians errors are basically identical since only 1 of the 10 training reactions was not added by me i.e. only 1 reaction does not use thermo from my library. Sorry to not use the correct list of thermo libraries the first time around.
tree_fitting_notebooks.zip

@kspieks kspieks requested a review from xiaoruiDong March 28, 2022 23:37
@kspieks kspieks self-assigned this Mar 28, 2022
Copy link
Contributor

@xiaoruiDong xiaoruiDong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good!

@xiaoruiDong xiaoruiDong merged commit c9bf474 into main Mar 30, 2022
@xiaoruiDong xiaoruiDong deleted the refit_1,3_sigmatropic branch March 30, 2022 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants