Refit 1,3 sigmatropic #575
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, #565 added 1D rotor scans on the reactants and products to improve the estimations from the thermo library. Scans were also done on the TS to improve A-factors for the training reactions used to fit the rate trees. However, when using ATG, this previous PR used the following set of thermo libraries:
thermo_libraries = ['Spiekermann_refining_elementary_reactions', 'primaryThermoLibrary']. However, our convention should be to useand then append my thermo library to the front. This is the same list in our ATG notebook as well as our ATG script.
Thus, this PR refits the rate rules using the updated list of thermo libraries, which is especially important since family is its own reverse. When looking at
rules.py, it appears there are many changes to the tree. However, the mean and median error are basically identical to what was calculated before. This can be see by looking at the last few cells in the old and new notebooks attached below. It makes sense that the mean and medians errors are basically identical since only 1 of the 10 training reactions was not added by me i.e. only 1 reaction does not use thermo from my library. Sorry to not use the correct list of thermo libraries the first time around.tree_fitting_notebooks.zip