Fix and re-add verbose comments back to RMG #740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…argument to fillKineticsRulesByAveragingUp Set this to False by default, or to the method preferred in the input file's options: verboseComments
…Kinetics() For rate rules that get created during fillRulesByAveragingUp, the kinetics comments retain verbose information about kinetic sources. However, if averaging is performed during the selection of best kinetics in estimateKinetics(), this information was not retained, so it must be added here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #713, we removed true verbose comments due to high memory usage. Turns out the memory consumption was partially due to incorrect kinetic comments. These commits try to fix the verbose comments for kinetics (turned on when the
input.pyfile containsoptions(verboseComments=True).) This should print out all the original rule rules which actually contain data.Turning on
verboseCommentsstarts out with memory usage around 1 GB, and with it off the memory usage starts at around 300 MB.