Added Julia into the conda rmg_env #2280
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I've had a lot of issues with the conda-forge binaries, so I compiled my own (that are on the rmg channel) and pyjulia has them as a dependency so it shouldn't be strictly necessary to specify julia, although perhaps we should. The main issue I had with the conda-forge binaries as far as I'm aware is fixed now, but I could never get the environment to build with the binaries from conda-forge. |
Member
Author
|
I see. Also, neither of the tests liked my change, closing PR |
Contributor
|
This ultimately came up again in #2415 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation or Problem
New users installing RMG from source get stuck when executing
python -c "import julia; julia.install(); import diffeqpy; diffeqpy.install()"since
Juliaisn't present in thermg_envDescription of Changes
Added Julia into the conda environment
Reviewer Tips
From my experience this addition is required to run RMG when building a fresh env, I'm surprised that the current tests do pass w/o it, so perhaps I'm wrong. Could use another set of eyes.