-
Notifications
You must be signed in to change notification settings - Fork 250
Improve conda installation instructions #2246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sevyharris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I think it should be ready to go after the two tabs are added so the HTML builds properly.
documentation/source/users/rmg/installation/anacondaDeveloper.rst
Outdated
Show resolved
Hide resolved
|
Something like this came up in #2437 - the Docker image and CI use miniconda, which does not follow the developer installation instructions. For the same reasons listed in this PR, this should be changed. I am going to resolve the merge conflicts and get this ready to merge, since the same points made are still relevant. @sevyharris could you review after? |
|
Also adding that almost all of the content that was originally in this PR (like |
|
So you want me to tidy it up? |
Nope, there was only one conlict, which I resolved. The rest of the changes were already present, so they did not raise conflicts when updating. Thanks for checking in though! |
Codecov Report
@@ Coverage Diff @@
## main #2246 +/- ##
=======================================
Coverage 48.13% 48.13%
=======================================
Files 110 110
Lines 30626 30626
Branches 7988 7988
=======================================
Hits 14743 14743
Misses 14353 14353
Partials 1530 1530 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I fixed the issues Sevy noted, and added some more edits. |
…nda for proper locations, updates; switch to Miniconda to reduce download and installation size by 10x; replace deprecated "source" with "conda"
Whitespace is crucial, a bit like in Python. One needs to actually compile in sphinx and look at the output to be sure.
Make a sub-list for different package managers. Tweak the MacOS instructions wording.
JacksonBurns
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Motivation or Problem
Writing the documentation to only reference Anaconda is inflexible and bloated as compared with utilizing Miniconda or Conda available in system repositories. This is of particular relevance of storage-limited systems, such as shared high-performance resources where RMG is often installed (which also frequently run RHEL or another Enterpise Linux which includes
condain the repositories, easing administrative burden).Description of Changes
sourcewithcondain activating environmentsTesting
Environments created and RMG-Py, RMG-database installed and tested on Fedora and EL systems