Skip to content

Conversation

@HermanPlay
Copy link
Contributor

This pull request introduces several enhancements to the deployment process, including the integration of Cert-Manager for TLS/SSL management, monitoring improvements with a PostgreSQL exporter, and configuration updates for better usability and functionality. Below is a summary of the most important changes grouped by theme:

Cert-Manager Integration:

  • Added the Jetstack Helm repository and installed Cert-Manager in the deployment workflow (.github/workflows/deploy.yaml).
  • Created a letsencrypt-prod Issuer resource for managing TLS certificates (helm/templates/security/prod-issuer.yaml).
  • Updated the web app's Ingress resource to include TLS configuration and annotations for Cert-Manager (helm/templates/webapp/ingress.yaml). [1] [2]

Monitoring Enhancements:

  • Added a PostgreSQL exporter deployment, service, and ServiceMonitor for Prometheus monitoring (helm/templates/database/exporter.yaml).
  • Enabled monitoring components in the GKE cluster configuration (infrastructure/gke.tf).

Deployment and Configuration Updates:

  • Updated the Helm deployment script to include Cert-Manager installation and additional Helm repository updates (deploy.sh). [1] [2]
  • Modified Helm values to include default secrets, URLs, and issuer configurations (helm/values.yaml). [1] [2]

Bug Fixes:

  • Corrected a typo in the NEXT_PUBLIC_APP_URL environment variable key in the web app deployment template (helm/templates/webapp/deployment.yaml).

@HermanPlay HermanPlay requested a review from a team as a code owner May 12, 2025 22:45
@HermanPlay HermanPlay requested a review from Copilot May 18, 2025 10:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the deployment process by integrating Cert-Manager for TLS management, adding monitoring support for PostgreSQL, and updating deployment configurations for improved usability.

  • Added a monitoring configuration block to the GKE cluster resource.
  • Introduced new environment variables and Stripe configuration in Helm values and deployment templates.
  • Updated the deployment script to include a repository update and modified issuer flags.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
infrastructure/gke.tf Added monitoring_config block, but the value for enable_components may need adjustment.
helm/values.yaml Added Stripe keys and enabled Grafana default dashboards to support monitoring enhancements.
helm/templates/webapp/ingress.yaml Updated Ingress TLS hosts and standardized service name quoting.
helm/templates/webapp/deployment.yaml Added Stripe environment variables; note a typo in the webhook secret key name.
helm/templates/security/prod-issuer.yaml Removed conditional templating for issuer configuration.
deploy.sh Updated Helm deploy script to include repo updates and modified issuer flag for deployment.
.github/workflows/deploy.yaml Updated secret settings and issuer flag, although a configuration inconsistency exists.
Comments suppressed due to low confidence (2)

infrastructure/gke.tf:21

  • The value 'SCHEDULER' may require quoting or wrapping in a list depending on Terraform's expected type for enable_components. Please verify if it should be written as ["SCHEDULER"] or "SCHEDULER".
enable_components = SCHEDULER

deploy.sh:50

  • The issuer.enabled flag is set to false in deploy.sh while it is set to true in the GitHub workflow. Ensure that this discrepancy is intentional to avoid deployment inconsistencies.
--set issuer.enabled=false

HermanPlay and others added 8 commits May 18, 2025 10:39
matined
matined previously approved these changes May 18, 2025
@HermanPlay HermanPlay merged commit 2b34e18 into master May 18, 2025
3 checks passed
@HermanPlay HermanPlay deleted the feat/grafana-dashboard branch May 18, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants