Fix #7354, Implementing NSE in cube#7603
Fix #7354, Implementing NSE in cube#7603sisyphuswastaken wants to merge 16 commits intoRdatatable:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7603 +/- ##
==========================================
- Coverage 99.04% 99.02% -0.02%
==========================================
Files 87 87
Lines 17031 17095 +64
==========================================
+ Hits 16868 16928 +60
- Misses 163 167 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
I've added new tests for code coverage, and tried to undo the unnecessary changes that occurred when I had replaced the full function while integrating |
|
Hello! Bumping on this, let me know if any changes are to be made to the PR, I'd be happy to adjust :) @jangorecki |
|
sorry for the delays, I was swamped with assignments but I'll push changes within this week. Also since I made a new branch, it seems as if some of my changes (the use of the helper function in [.data.table) weren't transferred properly. I'll fix that and have the changes ready for review within this week. I apologize for the inconvenience caused. |
Pertains to issue #7354.
Changes implemented:
This PR continues work from Implementing NSE in cube #7540 and and Implementing NSE in cube #7543.