Make litedown vignettes compatible with pkgdown #7402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Yihui Xie <xie@yihui.name>
Since we register a method for knitr::knit_print, keep it mentioned in the DESCRIPTION.
As with knit_print, avoid printing x when !shouldPrint(x). Use the overloaded method in the vignettes instead of relying on the auto-printing detection in print.data.table.
rikivillalba
requested review from
a team,
MichaelChirico,
jangorecki and
tdhock
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## litedown #7402 +/- ##
=========================================
Coverage 99.08% 99.08%
=========================================
Files 83 83
Lines 15800 15735 -65
=========================================
- Hits 15655 15591 -64
+ Misses 145 144 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
I thought we have some workaround implemented for that in CI, but couldn't find it now. If there is we could possibly remove if this PR is merged. |
Contributor
There was a problem hiding this comment.
@rikivillalba ? you do not change the date with date: !r Sys.Date()
Same remark applies to the EN vignette.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6583
The purpose of this PR is to allow the vignettes to be rendered with litedown while still being compatible with rmarkdown since pkgdown uses rmarkdown to build the site. Some modifications were made:
{r} Sys.date()inline codes changed to !r Sys.date() (EDIT: this works in the YAML header only). They re compatible by both litedown and knitr/rmarkdown unliker Sys.date()(knitr only) and{r} Sys.date()(litedown only)