Skip to content

Conversation

@ChristianWia
Copy link
Contributor

@ChristianWia ChristianWia commented Jul 15, 2025

accurate for -joins only (see remarks below)

@codecov
Copy link

codecov bot commented Jul 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.77%. Comparing base (7f14f2e) to head (c7603ef).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7179   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files          81       81           
  Lines       15218    15218           
=======================================
  Hits        15032    15032           
  Misses        186      186           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@aitap aitap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of these turned out to be quotes.

@ChristianWia ChristianWia requested a review from AngelFelizR July 15, 2025 21:50
@MichaelChirico
Copy link
Member

MichaelChirico commented Jul 15, 2025

Would you mind adjusting the PR title and description to be more informative? Thanks!

done.

@ChristianWia ChristianWia changed the title Christian wia patch 1 change quote to Note in vignettes datatable-joins.Rmd Jul 15, 2025
@AngelFelizR
Copy link
Contributor

AngelFelizR commented Jul 16, 2025

I think it could be better to use "Note:" to highlight the note

@ChristianWia
Copy link
Contributor Author

I think it could be better to use "Note:" to highlight the note

done on both -joins.Rmd EN and FR.

@tdhock
Copy link
Member

tdhock commented Jul 16, 2025

files changed shows all lines changes in vignette, please fix line endings so that only the relevant changes are shown.

@tdhock
Copy link
Member

tdhock commented Jul 16, 2025

#7184 was merged which fixed line endings

@MichaelChirico
Copy link
Member

Certain markdown flavors support nice highlighting of notes:

https://github.com/orgs/community/discussions/16925

That said, this will mostly be rendered on CRAN / pkgdown bootstrap, which don't have similar sentinels AFAIK.

@MichaelChirico MichaelChirico merged commit c8bbb58 into master Jul 22, 2025
9 checks passed
@MichaelChirico MichaelChirico deleted the ChristianWia-patch-1 branch July 22, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants