-
Notifications
You must be signed in to change notification settings - Fork 1k
change quote to Note in vignettes datatable-joins.Rmd #7179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
substitue '>' by 'Note:'
substitue > by Notes:
substitue > by Note:
substitue > by Note:
substitue > by Note:
substitue > by Note :
substitue > by Note :
subshitue > by Note :
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7179 +/- ##
=======================================
Coverage 98.77% 98.77%
=======================================
Files 81 81
Lines 15218 15218
=======================================
Hits 15032 15032
Misses 186 186 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aitap
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of these turned out to be quotes.
|
Would you mind adjusting the PR title and description to be more informative? Thanks! done. |
|
I think it could be better to use "Note:" to highlight the note |
done on both -joins.Rmd EN and FR. |
|
files changed shows all lines changes in vignette, please fix line endings so that only the relevant changes are shown. |
|
#7184 was merged which fixed line endings |
|
Certain markdown flavors support nice highlighting of notes: https://github.com/orgs/community/discussions/16925 That said, this will mostly be rendered on CRAN / pkgdown bootstrap, which don't have similar sentinels AFAIK. |
accurate for -joins only (see remarks below)