Refactor path handling for cross-platform robustness #3
Conversation
- Created `src/code_trajectory/path_utils.py` to centralize path normalization and checks. - Updated `recorder.py`, `trajectory.py`, `watcher.py`, and `server.py` to use `path_utils`. - Fixed potential Git tree traversal issue on Windows by enforcing POSIX paths. - Improved path comparison logic to be robust against case sensitivity and symlinks. - Verified all tests pass.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
This PR addresses potential logical errors and cross-platform issues related to path handling.
It introduces a
path_utilsmodule to manage path normalization, ensuring consistent behavior across Windows, Linux, and macOS.Specifically, it ensures that paths passed to GitPython for tree traversal are always POSIX-style (forward slashes), preventing errors on Windows.
It also replaces fragile string-based path checks with robust
pathlibbased comparisons.PR created automatically by Jules for task 13747882425432013982 started by @SynTaek