Conversation
Co-authored-by: Chris Zetter <zetter-rpf@users.noreply.github.com>
Co-authored-by: Chris Zetter <zetter-rpf@users.noreply.github.com>
Co-authored-by: Chris Zetter <zetter-rpf@users.noreply.github.com>
Co-authored-by: Chris Zetter <zetter-rpf@users.noreply.github.com>
Co-authored-by: Chris Zetter <zetter-rpf@users.noreply.github.com>
Co-authored-by: Chris Zetter <zetter-rpf@users.noreply.github.com>
Co-authored-by: Chris Zetter <zetter-rpf@users.noreply.github.com>
Co-authored-by: Chris Zetter <zetter-rpf@users.noreply.github.com>
Co-authored-by: Chris Zetter <zetter-rpf@users.noreply.github.com>
|
We require contributors to sign our Contributor License Agreement, and we don't have you on file. In order for us to review and merge your code, please complete this form and we'll get you added and review your contribution as soon as possible. |
Co-authored-by: Chris Zetter <zetter-rpf@users.noreply.github.com>
|
We require contributors to sign our Contributor License Agreement, and we don't have you on file. In order for us to review and merge your code, please complete this form and we'll get you added and review your contribution as soon as possible. |
Test coverage89.07% line coverage reported by SimpleCov. |
There was a problem hiding this comment.
Pull request overview
This pull request migrates the CI/CD infrastructure from CircleCI to GitHub Actions. The change is motivated by organizational shift away from CircleCI and a desire to potentially reduce test flakiness through a different test environment. The migration is comprehensive, removing all CircleCI artifacts and replacing them with equivalent GitHub Actions workflows.
Changes:
- Replaced CircleCI configuration with a GitHub Actions workflow that runs linting and tests
- Implemented custom bash scripts for test coverage reporting via PR comments
- Updated development environment configuration by removing CircleCI-specific extensions
- Updated documentation to reflect the new CI platform
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| AGENTS.md | Updated CI documentation to reference GitHub Actions with Ruby 3.4, Postgres 12, Redis |
| .github/workflows/ci.yml | New CI workflow with lint and test jobs, including postgres and redis services, coverage reporting |
| .github/scripts/post_coverage_comment.sh | New script to post or update coverage comments on PRs using GitHub API |
| .github/scripts/build_coverage_comment.sh | New script to parse SimpleCov coverage data and format it for PR comments |
| .devcontainer/devcontainer.json | Removed CircleCI VSCode extension from development container |
| .circleci/record_coverage | Deleted legacy CircleCI coverage recording script |
| .circleci/config.yml | Deleted legacy CircleCI configuration file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
adrian-rpf
left a comment
There was a problem hiding this comment.
Looks good.
Just the question on if you think the EDITOR_ENCRYPTION_KEY should be excluded.
Status
What's changed?
Replace our Circle CI integration with Github actions.
My motivation for doing this now was a flakey test in https://github.com/RaspberryPiFoundation/digital-editor-issues/issues/1144
It's possible that the different test environment may reduce flakyness.
Steps to perform after deploying to production