fix: Improve fallback for getInitialCandidate#9941
Open
microbit-robert wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
This PR improves the
getInitialCandidatefallback to the nearest parent block that has a compatible connection. This handles the case where a nested value block (e.g. a number input) has passive focus but the dragged block (inserted via keyboard from the flyout) is a statement block that should be inserted after the containing statement block.This PR would benefit from thorough review and testing to ensure that there aren't any unintended consequences.
Fixes #9899
Test Coverage
None
Documentation
No
Additional Information
N/A