fix: Fix bug that caused blocks inserted via Enter to not attach#9699
Open
fix: Fix bug that caused blocks inserted via Enter to not attach#9699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
This PR fixes a bug where inserting a block from the flyout using Enter (but not M) would insert it in move mode but with no potential candidate connections, meaning it could only be positioned via unconstrained move mode. The behavior is now identical whether you're using M or Enter. I also updated a test to ensure that inserting a block with Enter results in an insertion marker being displayed, meaning that the insertion is in constrained move mode.