Skip to content

fix: Fix typo in unregisterWorkspace function name #9559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
suk-6 wants to merge 4 commits into
base: main
Choose a base branch
from
+30 −1
Open

fix: Fix typo in unregisterWorkspace function name #9559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
84e6dbc
fix: Fix typo in unregisterWorkspace function name
suk-6 Jan 9, 2026
558024e
fix: Add deprecation warning for unregisterWorkpace function
suk-6 Jan 10, 2026
f0a303d
fix: Add renaming entry for unregisterWorkspace in version 13.0.0
suk-6 Jan 10, 2026
df7bc53
fix(typo): "." -> "," in renamings.json5
suk-6 Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion core/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
import {getFocusManager} from './focus_manager.js';
import {ISelectable, isSelectable} from './interfaces/i_selectable.js';
import {ShortcutRegistry} from './shortcut_registry.js';
import { deprecation } from './utils.js';

Check failure on line 18 in core/common.ts

View workflow job for this annotation

GitHub Actions / lint 

Replace `·deprecation·` with `deprecation`
import type {Workspace} from './workspace.js';
import type {WorkspaceSvg} from './workspace_svg.js';

Expand Down Expand Up @@ -58,10 +59,27 @@
*
* @param workspace
*/
export function unregisterWorkpace(workspace: Workspace) {
export function unregisterWorkspace(workspace: Workspace) {
delete WorkspaceDB_[workspace.id];
}

/**
* Unregister a workspace from the workspace db.
*
* @deprecated v12: use Blockly.common.unregisterWorkspace
* @param workspace
*/
export function unregisterWorkpace(workspace: Workspace) {
deprecation.warn(
'Blockly.common.unregisterWorkpace',
'v12',
'v13',
'Blockly.common.unregisterWorkspace',
);

unregisterWorkspace(workspace);
}

/**
* The main workspace most recently used.
* Set by Blockly.WorkspaceSvg.prototype.markFocused
Expand Down
11 changes: 11 additions & 0 deletions scripts/migration/renamings.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1595,5 +1595,16 @@
},
],

'13.0.0': [
{
oldName: 'Blockly.common',
exports: {
unregisterWorkpace: {
newExport: 'unregisterWorkspace',
},
},
},
],

'develop': [],
}
Loading