Skip to content

fix: dont use gulp streams for simple copying#2681

Merged
maribethb merged 2 commits intoRaspberryPiFoundation:mainfrom
maribethb:gulp-copy
Apr 10, 2026
Merged

fix: dont use gulp streams for simple copying#2681
maribethb merged 2 commits intoRaspberryPiFoundation:mainfrom
maribethb:gulp-copy

Conversation

@maribethb
Copy link
Copy Markdown
Contributor

The basics

The details

Resolves

Fixes #2603

Proposed Changes

Uses fs methods for copying files instead of gulp streams

Reason for Changes

  • gulp streams have overhead we don't need just to copy files without modification
  • gulp streams set utf-8 encoding by default which was mangling our binary files (like pngs in blockly/media)

Test Coverage

Ran npm run test:ghpages to run the site locally and verified the trashcan issue is resolved and sounds now work in examples

Documentation

n/a

Additional Information

@maribethb maribethb requested a review from a team as a code owner April 1, 2026 15:20
@maribethb maribethb requested review from mikeharv and removed request for a team April 1, 2026 15:20
Copy link
Copy Markdown
Contributor

@mikeharv mikeharv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a solid fix!

@maribethb maribethb merged commit 46a2dd1 into RaspberryPiFoundation:main Apr 10, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken trashcan in examples/backpack-demo/index.html

2 participants