Replace Symfony Exception Handler with Spatie Ignition #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AliceKLWilliams @adamtomat Is there a possibility that you merge these changes? :) |
Closed
Merged
Collaborator
|
This is being implemented as part of 8.0 (#61) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Replaces the Symfony Exception Handler with the Spatie Ignition package - https://github.com/spatie/ignition. This provides a nicer debugging experience as the error page can show you the code in which the error was thrown, for example in this image from their Github repo:
Does this close any currently open issues?
#32 - This issue requested we move to the Laravel exception handler (which at the time was Whoops), but Laravel have now moved to use Spatie Ignition.
#54 - This PR replaces the Symfony exception handler, so these deprecation errors will no longer appear.
Any other comments?
Some of the work on #52 will no longer be required, as the error handler has been replaced