fix: theme toggle dropdown not showing #64
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert ThemeTrigger to use React.forwardRef to properly work with Radix UI's PopoverTrigger asChild pattern, which requires child components to forward refs for click handlers to work.
Contributor
|
@Melvynx is attempting to deploy a commit to the Tinte Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
trying to fix this button that doesn't work anymore : |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ThemeTriggerto useReact.forwardRefto properly work with Radix UI'sPopoverTrigger asChildpatternTest plan
/workbench