Cleanup: Clarify the purpose and units of various numbers in lifecycle.js #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
H4ad
approved these changes
Dec 20, 2025
Collaborator
|
Just need to change the commit message to prefix with "refactor:" |
RafaelGSS
approved these changes
Dec 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In trying to determine if there was a problem with long-running tests, I found a number of spots that looked like potential issues but turned out to be nothing.
This PR documents some units and the actual meaning of minTime, and rearranges and renames a few intermediate calculations in the hopes that the code will be easier to scan for the next person trying to debug an unexpected behavior.