Fix warming and configuration change issues with detectDeadCodeElimination=true #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…deElimination=true Avoid configuration changes mid-run, and move warnings to the top of the output. As previously implemented, the worker mode warnings would be issued once per benchmark, interlaced with them, and with DCE enabled wouldn't issue a warning at all. Putting the warnings in the middle of the test output is more likely to be missed by a user, lost in the noise. This change also settles the issue of which plugins we are running to the constructor, also avoiding 1) re-writing the benchmark string after creation 2) rewriting the benchmark string after warming has already supposedly completed
jdmarshall
force-pushed
the
warmupLifecycle
branch
from
97c34a5 to
9cd8189
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid configuration changes mid-run, and move warnings to the top of the output.
As previously implemented, the worker mode warnings would be issued once per benchmark, interlaced with them, and with DCE enabled wouldn't issue a warning at all.
Putting the warnings in the middle of the test output is more likely to be missed by a user, lost in the noise. This change also settles the issue of which plugins we are running to the constructor, also avoiding