Rework reporters to support string output of format instead of stdout #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missed some duplications of code previously moved to summarize()
This should unroll most of the rest of the difficult stdout.write unwrapping.
jdmarshall
force-pushed
the
stringify
branch
2 times, most recently
from
60ebad5 to
90581b7
Compare
Collaborator
Author
|
I think once this lands I can declare 1.0 on my benchmark-regression replacement module. |
Owner
|
Can you please summarize the changes in the PR description? This goes to changelog. |
Collaborator
Author
|
@RafaelGSS as of this morning, you and I are dev dependencies on the prom-client project |
RafaelGSS
approved these changes
Nov 27, 2025
Owner
|
Uh, I should have squashed these commits. Let me adjust manually on main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate output formatting from writing to stdout.
Useful for writing reports to files or composing the output such as in regression testing.
#119