Skip to content

remove spiceypy dependency with updated lunarsky#1671

Open
aelanman wants to merge 2 commits into
mainfrom
make_bland
Open

remove spiceypy dependency with updated lunarsky#1671
aelanman wants to merge 2 commits into
mainfrom
make_bland

Conversation

@aelanman
Copy link
Copy Markdown
Contributor

Description

The latest version of lunarsky drops the dependency on spiceypy. As a result, the try blocks that catch SPICEUnknownFrameErrors in unit tests can be removed. This also bumps the minimum version of lunarsky.

Motivation and Context

This cleans up code that will no longer be needed.

Build or continuous integration change checklist:

  • If required or optional dependencies have changed (including version numbers), I have updated the readme to reflect this.
  • If this is a new CI setup, I have added the associated badge to the readme and to references/make_index.py (if appropriate).

@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.93%. Comparing base (2f7953d) to head (5b1c430).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1671   +/-   ##
=======================================
  Coverage   99.93%   99.93%           
=======================================
  Files          67       67           
  Lines       22848    22848           
=======================================
  Hits        22834    22834           
  Misses         14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bhazelton
Copy link
Copy Markdown
Member

bhazelton commented May 15, 2026

Thanks @aelanman! Obviously tests won't pass until the new lunarsky version is released but it's nice to have this ready to go when it is released. There's several other places in the repo where the lunarsky dependency is set, so we'll need to update those as well. Off the top of my head that includes:

  • CI conda yamls
  • environment.yaml
  • readme

Maybe just search the repo to see if there are any more. We also usually put something in the changelog when we increase dependency versions, you can see examples in there from earlier lunarsky version bumps.

@aelanman
Copy link
Copy Markdown
Contributor Author

Thanks for the reminder about the changelog @bhazelton ! I've added to that (and for pyuvsim) and updated the README and environment.yaml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants