ENH: Require attenuation map for JosephAttenuated projection methods #876
+18
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axel-grc
force-pushed
the
AttenuationMap
branch
from
2ff8615 to
ed1c7ae
Compare
axel-grc
changed the title
axel-grc
force-pushed
the
AttenuationMap
branch
from
ed1c7ae to
7f20145
Compare
SimonRit
requested changes
Dec 20, 2025
Collaborator
SimonRit
left a comment
SimonRit
left a comment
There was a problem hiding this comment.
Thanks. There should be an error message at the application level as you suggest. But there should also be an exception raised in JosephBackAttenuatedProjectionImageFilter as you had initially suggested.
axel-grc
force-pushed
the
AttenuationMap
branch
from
7f20145 to
57caba3
Compare
SimonRit
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #452