[style][components/fal_rtt] misrac style #11178
Open
+17
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[
为什么提交这份PR (why to submit this PR)
在 RT-Thread 的 FAL(Flash Abstraction Layer)相关实现中,
部分代码存在在条件判断中直接进行赋值的写法,例如:
虽然该写法在功能上是正确的,但可读性较差,
并且在代码维护、review 以及静态代码分析场景下容易引起歧义。
本 PR 对上述写法进行了重构,旨在提升代码可读性、可维护性,
并降低后续维护和分析的理解成本。
你的解决方案是什么 (what is your solution)
本 PR 通过将“函数返回值赋值”和“条件判断”进行拆分,
使代码逻辑更加清晰、直观,具体包括:
falshell 命令中 flash 设备与分区探测逻辑本次修改不引入新功能,也不改变现有接口及运行行为。
请提供验证的 bsp 和 config (provide the config and bsp)
本 PR 未涉及 BSP 或配置项的修改。
BSP:未更改
.config:无更改
action:无
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up