Skip to content

Conversation

@hzy0117
Copy link
Contributor

@hzy0117 hzy0117 commented Oct 27, 2025

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

HAL_Drivers/config/ra2a1这些配置文件已经移动到/drivers下,在pwm_config里新增对BSP_USING_PWM10到BSP_USING_PWM12的定义

你的解决方案是什么 (what is your solution)

在pwm_config里新增对BSP_USING_PWM10到BSP_USING_PWM12的定义

请提供验证的bsp和config (provide the config and bsp)

  • BSP:rt-thread\bsp\renesas
  • .config:暂无
  • action:暂无

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@hzy0117 hzy0117 requested a review from Rbb666 as a code owner October 27, 2025 13:49
@CLAassistant
Copy link

CLAassistant commented Oct 27, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added BSP BSP: Renesas BSP related with Renesas labels Oct 27, 2025
@hzy0117 hzy0117 changed the title [BSP][renesas][rsoc][fix]:移除HAL_Drivers/config/ra2a1 [BSP][renesas][rsoc][fix]:移除HAL_Drivers/config/ra2a1并在pwm_config里新增对BSP_USING_PWM10到BSP_USING_PWM12的定义 Oct 27, 2025
@CYFS3
Copy link
Contributor

CYFS3 commented Oct 27, 2025

#10812 已经删除config的文件了,这边就不需要删除了,原本也是让你拆分commit分成两个pr。

@CYFS3
Copy link
Contributor

CYFS3 commented Oct 27, 2025

修改完之后,把pr的标题也修改一下

@hzy0117
Copy link
Contributor Author

hzy0117 commented Oct 28, 2025

config空文件夹已删除

@Rbb666
Copy link
Member

Rbb666 commented Oct 28, 2025

@hzy0117 签署下CLA

@Rbb666 Rbb666 added this to the v5.2.2 milestone Oct 28, 2025
@Rbb666 Rbb666 changed the title [BSP][renesas][rsoc][fix]:移除HAL_Drivers/config/ra2a1并在pwm_config里新增对BSP_USING_PWM10到BSP_USING_PWM12的定义 [BSP][renesas][fix]:移除HAL_Drivers/config/ra2a1并在pwm_config里新增对BSP_USING_PWM10到BSP_USING_PWM12的定义 Oct 28, 2025
@Rbb666 Rbb666 changed the base branch from v5.2.2-beta to master October 28, 2025 04:47
@Rbb666 Rbb666 requested a review from kurisaW as a code owner October 28, 2025 04:47
@github-actions
Copy link

📌 Code Review Assignment

🏷️ Tag: bsp_renesas

Reviewers: @kurisaW

Changed Files (Click to expand)
  • bsp/renesas/libraries/HAL_Drivers/drivers/config/ra8/pwm_config.h
  • bsp/renesas/ra8d1-vision-board/board/Kconfig

📊 Current Review Status (Last Updated: 2025-10-28 13:34 CST)


📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@hzy0117 hzy0117 changed the title [BSP][renesas][fix]:移除HAL_Drivers/config/ra2a1并在pwm_config里新增对BSP_USING_PWM10到BSP_USING_PWM12的定义 [BSP][renesas][fix]:pwm_config里新增对BSP_USING_PWM10到BSP_USING_PWM12的定义 Oct 28, 2025
@Rbb666 Rbb666 merged commit c553df5 into RT-Thread:master Oct 28, 2025
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BSP: Renesas BSP related with Renesas BSP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants