Skip to content

Conversation

@xusiwei
Copy link
Contributor

@xusiwei xusiwei commented Oct 20, 2025

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

KERNEL_VADDR_START 的值来自 Kconfig:

#ifndef KERNEL_VADDR_START
#ifdef  KERNEL_ASPACE_START
#define KERNEL_VADDR_START KERNEL_ASPACE_START
#else
#define KERNEL_VADDR_START (ARCH_RAM_OFFSET + ARCH_TEXT_OFFSET)
#endif
#endif /* KERNEL_VADDR_START */

menuconfig 中配置的值,如果是 0x80100000 这样的值,在调用rt_aspace_init时,0 - KERNEL_VADDR_START 的值计算错误:

    rt_aspace_init(aspace, (void *)KERNEL_VADDR_START, 0 - KERNEL_VADDR_START,
                   vtable);

因为 0 的类型是 int0x80100000 的类型是 unsigned int,相减表达式的值也是 unsigned int,导致整型计算结果错误。

类似的测试代码:

#include <stdio.h>

#define KERNEL_VADDR_START 0x80100000

void foo(void* addr, size_t size)
{
	printf("addr: %p\n", addr);
	printf("size: %zx\n\n", size);
}

int main(int argc, char* argv[])
{
	foo((void*)KERNEL_VADDR_START, 0 - KERNEL_VADDR_START);
	foo((void*)KERNEL_VADDR_START, 0 - (size_t) KERNEL_VADDR_START);
	return 0;	
}

编译到64位目标平台,输出是:

addr: 0000000080100000
size: 7ff00000

addr: 0000000080100000
size: ffffffff7ff00000

你的解决方案是什么 (what is your solution)

参考rt_aspace_init接口定义:

rt_err_t rt_aspace_init(rt_aspace_t aspace, void *start, rt_size_t length, void *pgtbl);
0 - KERNEL_VADDR_START

修改为:

0 - (rt_size_t) KERNEL_VADDR_START

请提供验证的bsp和config (provide the config and bsp)

  • BSP: bsp\qemu-virt64-aarch64
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@github-actions
Copy link

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录(目录请以"/"结尾)
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to:aarch64
  • 设置PR number为 \ Set the PR number to:10833
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后,提交将自动更新至 aarch64 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the aarch64 branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions github-actions bot added Arch: ARM/AArch64 BSP related with arm libcpu labels Oct 20, 2025
@Rbb666 Rbb666 added this to the v5.2.2 milestone Oct 21, 2025
@Rbb666 Rbb666 merged commit 1efceab into RT-Thread:master Oct 21, 2025
55 checks passed
@Rbb666 Rbb666 linked an issue Oct 21, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Arch: ARM/AArch64 BSP related with arm libcpu

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] 5.2.2 版本需合并PR汇总

2 participants