Skip to content

utest: remove RT_UTEST_USING_ALL_CASES #10741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Rbb666 merged 1 commit into from
Sep 26, 2025
Merged

utest: remove RT_UTEST_USING_ALL_CASES #10741

Rbb666 merged 1 commit into from
Sep 26, 2025

Conversation

@unicornx
Copy link
Contributor

@unicornx unicornx commented Sep 25, 2025 •
edited
Loading

Fixed: #10734

由于目前很多模块的 utest 并不打算支持一次性统一开启，另外有些模块的测试由于比较复杂，譬如对其他模块有很多依赖，这导致简单通过一个全局开关来控制使能所有测试变得几乎不可能。这导致过去定义的 RT_UTEST_USING_ALL_CASES 已经失去了它最初的含义。

建议淘汰掉这个配置开关。如果某些模块内部觉得需要自己通过配置 enable 一批功能测试，那这种局部的 enable all 交给模块自己去实现，不再提供一个 RTT 全局的 enable 开关了。

如果以后再有此类一次性使能所有单元测试的需求，建议仔细设计一下，特别是要考虑从易用性上如何保证通过打开一个开关就能将所有涉及的模块的依赖关系全部都打开。

特别的 src/Kconfig 的这个改动请看一下是否合适？
519c9aa4d10981bb15ef7d619da42c13

@unicornx
utest: remove RT_UTEST_USING_ALL_CASES
73bb1e8 
Many modules' utests currently don't support enabling all
tests at once. Furthermore, some modules' tests are complex,
for example due to their numerous dependencies on other
modules. This makes it nearly impossible to enable all
tests with a single global switch. Consequently, the
previously defined `RT_UTEST_USING_ALL_CASES` has lost
its original meaning.

We recommend deprecating this configuration switch. If a
module needs to enable a group of functional tests through
its own configuration, this local enable all switch should
be implemented by the module itself, and a global RTT enable
switch will no longer be provided.

If such a requirement arises in the future, we recommend
careful design, especially considering how to ensure that
turning on a single switch enables all dependencies for
all involved modules for ease of use.

Signed-off-by: Chen Wang <unicorn_wang@outlook.com>
@github-actions
Copy link

github-actions bot commented Sep 25, 2025

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below.

🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录（目录请以"/"结尾）
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to：dev-rm-utest-all
  • 设置PR number为 \ Set the PR number to：10741
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后，提交将自动更新至 dev-rm-utest-all 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the dev-rm-utest-all branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions
Copy link

github-actions bot commented Sep 25, 2025

📌 Code Review Assignment

🏷️ Tag: bsp_k230

Reviewers: @unicornx

Changed Files (Click to expand)
  • bsp/k230/drivers/utest/SConscript

🏷️ Tag: components

Reviewers: @Maihuanyi

Changed Files (Click to expand)
  • components/drivers/audio/utest/SConscript
  • components/net/utest/SConscript
  • components/utilities/Kconfig
  • components/utilities/utest/utest/SConscript

🏷️ Tag: documentation

Reviewers: @CXSforHPU @GorrayLi @lianux-mm @unicornx

Changed Files (Click to expand)
  • documentation/6.components/utest/utest.md

🏷️ Tag: kernel

Reviewers: @GorrayLi @ReviewSun @hamburger-os @lianux-mm @wdfk-prog @xu18838022837

Changed Files (Click to expand)
  • src/Kconfig
  • src/klibc/utest/SConscript

📊 Current Review Status (Last Updated: 2025-09-25 14:15 CST)

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@unicornx unicornx requested review from kurisaW and removed request for Cathy-lulu September 25, 2025 06:17
@Rbb666 Rbb666 merged commit 495c8cf into RT-Thread:master Sep 26, 2025
70 checks passed
@unicornx unicornx deleted the dev-rm-utest-all branch September 26, 2025 05:48
@unicornx unicornx mentioned this pull request Sep 28, 2025
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rbb666 Rbb666 Rbb666 approved these changes

@mysterywolf mysterywolf Awaiting requested review from mysterywolf mysterywolf is a code owner

@kurisaW kurisaW Awaiting requested review from kurisaW

Assignees

No one assigned

Labels

BSP component: drivers/audio component: drivers component: net Component Doc This PR/issue related with documents Kernel PR has src relate code testcase

Projects

单元测试（UTEST）Framework
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature] 移除 RT_UTEST_USING_ALL_CASES

2 participants

@unicornx @Rbb666