Conversation
📌 Code Review Assignment🏷️ Tag: workflowReviewers: Rbb666 kurisaW supperthomas Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2025-08-06 17:26 CST)
📝 Review Instructions
|
2e876a9 to
be3cac7
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds adaptation support for the Raspberry Pi RP2350 microcontroller by creating a new BSP (Board Support Package). The RP2350 is a newer dual-core ARM Cortex-M33 microcontroller from Raspberry Pi with enhanced security features.
- New BSP implementation for raspberry-rp2350 based on existing raspberry-pico BSP
- Driver support for common peripherals including UART, GPIO, SPI, I2C, PWM, ADC, WDT, and RTC
- LVGL support for LCD display functionality
- Arduino compatibility layer for easier migration
Reviewed Changes
Copilot reviewed 56 out of 69 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| bsp/raspberry-rp2350/rtconfig.py | Build configuration script for ARM Cortex-M33 target |
| bsp/raspberry-rp2350/rtconfig.h | RT-Thread kernel and component configuration |
| bsp/raspberry-rp2350/link.ld | Linker script defining memory layout for RP2350 |
| bsp/raspberry-rp2350/drivers/* | Hardware abstraction layer drivers for peripherals |
| bsp/raspberry-rp2350/board/* | Board initialization and configuration |
| bsp/raspberry-rp2350/applications/* | Sample applications and Arduino pinout definitions |
Comments suppressed due to low confidence (1)
bsp/raspberry-rp2350/drivers/drv_soft_spi.h:46
- The macro name 'BSP_S_SPI_MOSI_PIN' should be 'BSP_S_SPI1_MOSI_PIN' to match the pattern used in other SPI1 pin definitions.
.mosi = BSP_S_SPI_MOSI_PIN, \
22b8d3e to
6a2f479
Compare
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
添加raspberry-rp2350适配
你的解决方案是什么 (what is your solution)
软件包索引仓库pr:
RT-Thread/packages#1917
软件包仓库pr:
RT-Thread-packages/raspberrypi-pico-rp2350-sdk#1
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up