[bsp][nxp][imx] Add FRDM-i.MX91 bsp #10570

xusiwei · 2025-07-31T15:57:48Z

拉取/合并请求描述：(PR description)

为什么提交这份PR (why to submit this PR)

添加 NXP FRDM-i.MX91 开发板的 BSP

你的解决方案是什么 (what is your solution)

新增imx91目录

请提供验证的bsp和config (provide the config and bsp)

BSP: FRDM-i.MX91

.config:

action:

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

已经仔细查看过代码改动的对比 Already check the difference between PR and old code
代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
代码是高质量的 Code in this PR is of high quality
已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

BernardXiong · 2025-08-01T03:53:18Z

A核芯片，请启用MMU，外设都做ioremap，谢谢。

Rbb666

请添加此BSP的CI看护

bsp/nxp/imx/imx91/applications/startup.c

bsp/nxp/imx/imx91/applications/SConscript

bsp/nxp/imx/imx91/applications/startup.c

Copilot

Pull Request Overview

This PR adds a new BSP (Board Support Package) for the NXP FRDM-i.MX91 development board, introducing support for the i.MX91 SoC with ARM Cortex-A55 architecture.

Key Changes:

Adds complete BSP structure for i.MX91 platform including toolchain configuration, memory management, and device drivers
Implements UART1 driver support with IOMUX configuration for serial communication
Provides basic board initialization with timer, interrupt handling, and memory mapping setup

Reviewed Changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated 11 comments.

Show a summary per file

File	Description
rtconfig.py	Toolchain configuration for ARM Cortex-A with GCC compiler settings
rtconfig.h	RT-Thread configuration header with i.MX91-specific settings
link.lds	Linker script defining memory layout and sections for i.MX91
drivers/serial.*	UART driver implementation and header
drivers/iomux/*	Pin multiplexing configuration for UART interfaces
drivers/board.*	Board initialization and hardware abstraction
applications/*	Application startup code and initialization
build files	SCons build system configuration and Kconfig files

bsp/nxp/imx/imx91/rtconfig.h

bsp/nxp/imx/imx91/drivers/imx91.h

bsp/nxp/imx/imx91/drivers/iomux/iomux_config.c

bsp/nxp/imx/imx91/drivers/board.h

bsp/nxp/imx/imx91/drivers/iomux/uart_iomux_config.c

bsp/nxp/imx/imx91/drivers/serial.h

bsp/nxp/imx/imx91/drivers/serial.c

bsp/nxp/imx/imx91/drivers/imx91.h

Copilot

Pull request overview

Copilot reviewed 76 out of 77 changed files in this pull request and generated 1 comment.

Copilot · 2025-12-09T02:06:25Z

bsp/nxp/imx/imx91/drivers/serial.h

+static inline void rt_hw_earlycon_putc(char) {}
+static inline void rt_hw_earlycon_puts(const char *) {}
+static inline void rt_hw_earlycon_print_hex(const char *, rt_base_t) {}


Missing parameter name in function declaration / 函数声明中缺少参数名

English: The inline function parameters are missing names. According to RT-Thread coding standards, parameter names should be included for better code readability.

中文:内联函数参数缺少名称。根据 RT-Thread 编码标准,应包含参数名称以提高代码可读性。

Example/示例:

static inline void rt_hw_earlycon_putc(char c) {} static inline void rt_hw_earlycon_puts(const char *str) {} static inline void rt_hw_earlycon_print_hex(const char *str, rt_base_t hex) {}

rcitach

这个文件是否必须存在

rcitach

注意

rcitach

rcitach

rcitach · 2025-12-09T06:35:33Z

bsp/nxp/imx/imx91/drivers/serial.c

+    config.bufsz     = RT_SERIAL_RB_BUFSZ;
+
+// #ifdef BSP_USING_EARLY_CONSOLE
+//     rt_ioremap_early((void*)CCM_CTRL_BASE, CCM_CTRL_SIZE);


对于启用MMU的soc,需要使用ioremap对外设做映射

rcitach · 2025-12-09T06:36:40Z

bsp/nxp/imx/imx91/drivers/board.c

+#endif
+
+    /* map LPUART1/CCM_CTRL/GIC_DISTRIBUTOR/GIC_REDISTRIBUTOR virtual address to equals physical address */
+    rt_ioremap_early((void*)LPUART1_BASE, GIC_REDISTRIBUTOR_BASE + GIC_REDISTRIBUTOR_SIZE - LPUART1_BASE);


mmu_setup之后 rt_ioremap_early 接口就不应该再继续使用了

xusiwei · 2025-12-09T07:56:03Z

A核芯片，请启用MMU，外设都做ioremap，谢谢。

done!

github-actions · 2025-12-09T19:26:43Z

📌 Code Review Assignment

🏷️ Tag: workflow

Reviewers: Rbb666 kurisaW supperthomas

Changed Files (Click to expand)

.github/ALL_BSP_COMPILE.json

📊 Current Review Status (Last Updated: 2025-12-12 00:47 CST)

⌛ Rbb666 Pending Review
⌛ kurisaW Pending Review
⌛ supperthomas Pending Review

📝 Review Instructions

维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
Maintainers can refresh the review status by clicking here: 🔄 Refresh Status
确认审核通过后评论 LGTM/lgtm
Comment LGTM/lgtm after confirming approval
PR合并前需至少一位维护者确认
PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

xusiwei · 2025-12-11T06:32:35Z

请添加此BSP的CI看护

Done

xusiwei requested a review from Rbb666 as a code owner July 31, 2025 15:57

github-actions bot added BSP: NXP Code related with NXP BSP labels Jul 31, 2025

xusiwei changed the title ~~[bsp][nxp][imx] Add FRDM-i.MX91 bsp~~ [bsp][nxp][imx] WIP: Add FRDM-i.MX91 bsp Jul 31, 2025

Rbb666 requested changes Aug 1, 2025

View reviewed changes

bsp/nxp/imx/imx91/applications/startup.c Outdated Show resolved Hide resolved

bsp/nxp/imx/imx91/applications/SConscript Outdated Show resolved Hide resolved

bsp/nxp/imx/imx91/applications/startup.c Outdated Show resolved Hide resolved

Rbb666 requested a review from Copilot August 5, 2025 10:56

Copilot AI reviewed Aug 5, 2025

View reviewed changes

xusiwei force-pushed the master branch 3 times, most recently from c2dcaac to c3195a7 Compare August 21, 2025 15:56

xusiwei force-pushed the master branch 3 times, most recently from 046d9d7 to 00b9b73 Compare September 11, 2025 13:55

xusiwei force-pushed the master branch 3 times, most recently from 6a4f223 to f96280f Compare October 17, 2025 15:57

Rbb666 added this to 单元测试（UTEST）Framework Nov 7, 2025

github-project-automation bot moved this to Todo in 单元测试（UTEST）Framework Nov 7, 2025

Rbb666 removed this from 单元测试（UTEST）Framework Nov 7, 2025

xusiwei force-pushed the master branch 4 times, most recently from cc65804 to f4a29eb Compare December 8, 2025 18:13

Rbb666 requested a review from Copilot December 9, 2025 02:03

Copilot started reviewing on behalf of Rbb666 December 9, 2025 02:04 View session

Copilot AI reviewed Dec 9, 2025

View reviewed changes

rcitach reviewed Dec 9, 2025

View reviewed changes

rcitach suggested changes Dec 9, 2025

View reviewed changes

rcitach approved these changes Dec 9, 2025

View reviewed changes

rcitach reviewed Dec 9, 2025

View reviewed changes

xusiwei changed the title ~~[bsp][nxp][imx] WIP: Add FRDM-i.MX91 bsp~~ [bsp][nxp][imx] Add FRDM-i.MX91 bsp Dec 9, 2025

xusiwei force-pushed the master branch 2 times, most recently from 33de741 to 45d4eec Compare December 9, 2025 19:26

xusiwei requested review from kurisaW and supperthomas as code owners December 9, 2025 19:26

github-actions bot added the action github action yml imporve label Dec 9, 2025

xusiwei force-pushed the master branch 5 times, most recently from efc16b5 to cbb41d3 Compare December 10, 2025 14:25

[bsp][nxp][imx] Add FRDM-i.MX91 support

802e26e

xusiwei force-pushed the master branch from cbb41d3 to b42186a Compare December 11, 2025 15:40

[bsp][nxp][imx] Fix i.MX91 access peripheral issues

69df92e

xusiwei force-pushed the master branch from b42186a to 69df92e Compare December 11, 2025 16:47

xusiwei requested a review from Rbb666 December 11, 2025 16:52

Rbb666 requested a review from rcitach December 12, 2025 01:39

rcitach approved these changes Dec 12, 2025

View reviewed changes

Rbb666 approved these changes Dec 12, 2025

View reviewed changes

Rbb666 merged commit b75828f into RT-Thread:master Dec 12, 2025
86 of 87 checks passed

[bsp][nxp][imx] Add FRDM-i.MX91 bsp #10570

[bsp][nxp][imx] Add FRDM-i.MX91 bsp #10570

Uh oh!

Conversation

xusiwei commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

拉取/合并请求描述：(PR description)

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

当前拉取/合并请求的状态 Intent for your PR

代码质量 Code Quality：

Uh oh!

BernardXiong commented Aug 1, 2025

Uh oh!

Rbb666 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes:

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

rcitach left a comment

Choose a reason for hiding this comment

Uh oh!

rcitach left a comment

Choose a reason for hiding this comment

Uh oh!

rcitach left a comment

Choose a reason for hiding this comment

Uh oh!

rcitach left a comment

Choose a reason for hiding this comment

Uh oh!

rcitach Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

rcitach Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

xusiwei commented Dec 9, 2025

Uh oh!

github-actions bot commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📌 Code Review Assignment

🏷️ Tag: workflow

📊 Current Review Status (Last Updated: 2025-12-12 00:47 CST)

📝 Review Instructions

Uh oh!

xusiwei commented Dec 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

xusiwei commented Jul 31, 2025 •

edited

Loading

github-actions bot commented Dec 9, 2025 •

edited

Loading