Bsp stm32f407 lckfb skystar auto hal#10511
Closed
wjjsn wants to merge 2 commits intoRT-Thread:masterfrom
Closed
Conversation
📌 Code Review Assignment🏷️ Tag: bsp_stm32Path: Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2025-07-15 04:10 UTC)
📝 Review Instructions
|
Member
|
这个是cube自动生成的,建议用cube生成一下, |
Author
|
有点不懂了,bsp完成开发之后作为使用者还是需要用到cubemx的吗? |
Member
嗯,底层厂商的自动生成的文件还是建议用cube生成,这样比较准确。以后别人用cube生成也比较方便 |
Author
|
哦,原来是这样,所以每次在menuconfig配置外设之后还要去cubemx配置一遍?这样是不是有点麻烦了,rtthread目标不是一站式的吗 |
Contributor
|
同样建议采用cubemx生成,这在stm32上是最佳实践。你可以根据开发板原理图,把原先cubemx未开启的外设都打开 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
在使用stm32f407-lckfb-skystar这个BSP的时候,发现勾选USB或其他外设后出现编译错误,经检查发现没有在
stm32f4xx_hal_conf.h文件自动解除对于HAL的使用的注释,导致编译时出现很多报错,而且在menuconfig已经配置了还需要再手动解除注释也麻烦。你的解决方案是什么 (what is your solution)
现在
stm32f4xx_hal_conf.h会自动根据rtconfig.h的内容自动配置BSP:bsp/stm32/stm32f407-lckfb-skystar
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up