MAINTAINER: standardize tag writing#10505
Merged
Rbb666 merged 1 commit intoRT-Thread:masterfrom Jul 14, 2025
Merged
Conversation
Update the tag writing requirements in the Note. It is recommended that the tag name directly refer to the module path in the code tree. For example, if the module path is 'bsp/cvitek', then the tag name should be 'bsp_cvitek'. And the name should be lowercase. According to the above rules, the tag name of the existing entries are adjusted. Other changes remain unchanged. Other text modifications are mainly to limit the width of each line, try not to exceed 80 columns. Signed-off-by: Chen Wang <unicorn_wang@outlook.com>
📌 Code Review Assignment🏷️ Tag: maintainersPath: Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2025-07-14 06:54 UTC)📝 Review Instructions
|
Rbb666
approved these changes
Jul 14, 2025
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
规范 tag 的写法
更新 Note 中对 tag 的编写要求，建议 tag 的命名直接参考模块在代码树种的路径，譬如如果模块路径是 'bsp/cvitek'，那么 tag 的名字就用 'bsp_cvitek'。而且命名用小写。这样便于统一大家的 tag 的命名，否则目前看上去比较混乱。
根据以上规则，调整了现有 entry 的 tag 名字。其他不变。
其他一些文本的修改主要是限制了每行的宽度，尽量不要超过 80 列。
拉取/合并请求描述：(PR description)
[
为什么提交这份PR (why to submit this PR)
你的解决方案是什么 (what is your solution)
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up