Feat 1 添加Liang He为bsp_stm32和 bsp_stm32f103-blue-pill,bsp_stm32f412-st-nucleo,driver_spi,tools模块的维护者 #10489
Closed
GPTKEY wants to merge 2 commits intoRT-Thread:masterfrom
GPTKEY:feat_1
Closed
Feat 1 添加Liang He为bsp_stm32和 bsp_stm32f103-blue-pill,bsp_stm32f412-st-nucleo,driver_spi,tools模块的维护者 #10489GPTKEY wants to merge 2 commits intoRT-Thread:masterfrom GPTKEY:feat_1
GPTKEY wants to merge 2 commits intoRT-Thread:masterfrom
GPTKEY:feat_1
Conversation
本PR不涉及代码更改,只提交了MAINTAINERS文件; ] 当前拉取/合并请求的状态 Intent for your PR 必须选择一项 Choose one (Mandatory): 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo 代码质量 Code Quality: 我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following: 已经仔细查看过代码改动的对比 Already check the difference between PR and old code 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky 代码是高质量的 Code in this PR is of high quality 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查
|
蓝夜 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
📌 Code Review Assignment🏷️ Tag: maintainersPath: Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2025-07-10 00:29 UTC)📝 Review Instructions
|
Contributor
Author
|
撤销 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
你的解决方案是什么 (what is your solution)
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up