Conversation
Contributor
Author
Rbb666
requested changes
Jul 4, 2025
tools/targets/keil.py
Outdated
|
|
||
| # The common part of making MDK4/5 project | ||
| def MDK45Project(tree, target, script): | ||
| def MDK45Project(env,tree, target, script): |
Rbb666
approved these changes
Jul 4, 2025
meng-plus
added a commit
to meng-plus/rt-thread
that referenced
this pull request
Jul 14, 2025
supperthomas
pushed a commit
that referenced
this pull request
Jul 15, 2025
[tools]:修复iar添加宏不完全 参考#10456
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
#10169 把env.Append(CPPDEFINES=['STM32F091xC'])放到了bsp顶层的Sconscript中,但是keil的宏定义是从组里面读取的,所以没有添加到对应型号的宏定义
你的解决方案是什么 (what is your solution)
宏定义从env的环境读取
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up