[pthreads] Fix pthread_cond_timedwait lacks timeout wakeup#10451
Merged
Rbb666 merged 1 commit intoRT-Thread:masterfrom Jul 25, 2025
Merged
[pthreads] Fix pthread_cond_timedwait lacks timeout wakeup#10451Rbb666 merged 1 commit intoRT-Thread:masterfrom
Rbb666 merged 1 commit intoRT-Thread:masterfrom
Conversation
📌 Code Review Assignment🏷️ Tag: componentsReviewers: @Maihuanyi Changed Files (Click to expand)
🏷️ Tag: components_libcReviewers: @GorrayLi @mysterywolf Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2025-07-24 14:59 CST)
📝 Review Instructions
|
mysterywolf
approved these changes
Jul 5, 2025
270ddb7 to
27c925b
Compare
Rbb666
approved these changes
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
修复#10444
你的解决方案是什么 (what is your solution)
原有实现中只是通过
rt_hw_interrupt_disable/enable进行保护,然而在rt_timer_control中会进行rt_enter/exit_critical操作,在rt_exit_critical时会进行rt_schedule发生调度,而这时rt_timer_start还未执行,导致超时唤醒丢失请提供验证的bsp和config (provide the config and bsp)
qemu-vexpress-a9
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up