Fix the crash of the SPI driver under the smart mode#10449
Merged
Rbb666 merged 1 commit intoRT-Thread:masterfrom Jul 4, 2025
Merged
Fix the crash of the SPI driver under the smart mode#10449Rbb666 merged 1 commit intoRT-Thread:masterfrom
Rbb666 merged 1 commit intoRT-Thread:masterfrom
Conversation
Signed-off-by: flyingcys flyingcys@163.com
📌 Code Review Assignment🏷️ Tag: bsp_cvitekPath: Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2025-07-01 15:00 UTC)
📝 Review Instructions
|
Contributor
Author
|
Z572 用户反馈 在smart下会奔溃,rt-thread下正常,删除该语句也可以正常工作。 |
unicornx
approved these changes
Jul 1, 2025
Contributor
unicornx
left a comment
There was a problem hiding this comment.
建议以后 commit 的 title 加上 "bsp: cvitek:" 前缀方便过滤区分。
其他没有问题。
Rbb666
approved these changes
Jul 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: flyingcys flyingcys@163.com
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
修复spi驱动在smart模式下奔溃
你的解决方案是什么 (what is your solution)
当前spi采用软件cs,不需要设置cs状态,删除对应语句
请提供验证的bsp和config (provide the config and bsp)
cvitek
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up