Open
Conversation
[Descriptions]:
1. Current default DFS_PATH_MAX is 4096, but it should be DIRENT_NAME_MAX.
BernardXiong
reviewed
Jul 5, 2025
|
|
||
| #ifndef DFS_PATH_MAX | ||
| #define DFS_PATH_MAX 4096 | ||
| #define DFS_PATH_MAX DIRENT_NAME_MAX |
Member
There was a problem hiding this comment.
谢谢提交。不过PATH_MAX似乎和dirent name_max的意思应该不一致才是。dirent name_max指的是一个direntry name的最大值,指的是单个的。而PATH_MAX指的是路径的最大值,应该是多级的关系。
这个问题需要对PATH_MAX做整体引用review后才能看到更清晰的情况。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Descriptions]:
1. Current default DFS_PATH_MAX is 4096, but it should be DIRENT_NAME_MAX.
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
The current default DFS_PATH_MAX is 4096, which is not correct
你的解决方案是什么 (what is your solution)
DFS_PATH_MAX should be DIRENT_NAME_MAX
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up