[components/libc] add comments for some pthread functions.#10423
[components/libc] add comments for some pthread functions.#10423Rbb666 merged 3 commits intoRT-Thread:masterfrom
Conversation
📌 Code Review Assignment🏷️ Tag: libcPath: Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2025-06-21 12:29 UTC)
📝 Review Instructions
|
There was a problem hiding this comment.
Pull Request Overview
This PR supplements function comments in the POSIX pthread implementation.
- Added detailed documentation for functions managing thread data structures, cleanup, and thread entry.
- Updated comments include synchronization notes, error return details, and resource cleanup order.
Comments suppressed due to low confidence (1)
components/libc/posix/pthreads/pthread.c:144
- The documentation for the function _destroy_item incorrectly describes its purpose as 'Create and initialize a new thread data structure'. Please update the comment to accurately reflect that it destroys and cleans up the thread data structure.
/**
|
关于commit提交描述,写成“任务1 函数注释补充”不好: |
另外,温馨提示一下:无需关闭PR再重新提交,只要在本地仓库用git rebase -i HEAD~2修改近两条commit信息(如果将两条提交合并成一条更好),然后git push --force即可。 如果本就知晓操作方式,请忽略这条消息。 |
任务1 函数注释补充.修改1 [components/libc] add comments for some pthread functions.
|
| * - Designed to be called during thread cleanup or explicit TLS destruction | ||
| * - Matches POSIX thread standard requirements for TLS destructor invocation | ||
| */ | ||
| static inline void git status(int index, _pthread_data_t *ptd) |
现在两个commit记录看上去有点奇怪,第一个还是中文,第二个commit diff只有两个空行。 |
…tus function to the _destroy_item function
|
建议作者把PR的标题修改成:xxx部分的函数注释补充,这样阅读性更佳 |
拉取/合并请求描述:(PR description)
[
新手任务1 函数注释补充,主要对libc/posix/pthread/pthread.c文件添加注释
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up