update(cherryusb): update to v1.5.0#10409
Merged
Rbb666 merged 2 commits intoRT-Thread:masterfrom Jun 20, 2025
Merged
Conversation
📌 Code Review Assignment🏷️ Tag: bsp_mcxnPath: Changed Files (Click to expand)
🏷️ Tag: bsp_rt-sparkPath: Changed Files (Click to expand)
🏷️ Tag: bsp_stm32Path: Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2025-06-19 12:32 UTC)
📝 Review Instructions
|
deec0b6 to
d71cc68
Compare
hywing
reviewed
Jun 18, 2025
| src = Split(""" | ||
| board.c | ||
| cherryusb_port.c | ||
| usb_phy.c |
Contributor
There was a problem hiding this comment.
usb_phy.c文件可以删除了么,我看见usb_phy.h也删掉了
Contributor
Author
There was a problem hiding this comment.
可以了,已经放在 port/nxp/usb_glue_mcx.c 里面了
Member
Contributor
Author
Signed-off-by: sakumisu <1203593632@qq.com>
22643e2 to
f5d59fe
Compare
Signed-off-by: sakumisu <1203593632@qq.com>
Rbb666
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


拉取/合并请求描述:(PR description)
ST board 中底层初始化不再需要,由cherryusb 中 usb_glue_st.c 实现
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up