componnets: utest: fix case-name matching problem#10381
Merged
Rbb666 merged 1 commit intoRT-Thread:masterfrom Jun 10, 2025
Merged
componnets: utest: fix case-name matching problem#10381Rbb666 merged 1 commit intoRT-Thread:masterfrom
Rbb666 merged 1 commit intoRT-Thread:masterfrom
Conversation
There is a problem with the matching of case names in the original code. Due to original code use memcmp with len, if the input case name and the existing case name have an inclusion relationship, for example, if the actual case name is "gpip_irq", and run `utest_run gpio` will also match successfully, but it's not expected. Modify the logic of exact matching and use strcmp instead. Keep the original wildcard logic, that is, `utest_run gpio*` can match both "gpio_irq" and "gpio". Signed-off-by: Chen Wang <unicorn_wang@outlook.com>
Contributor
Author
|
@Rbb666 静态检查的报错看上去和我的修改没有关系啊,请帮忙看一下呢。 |
Member
因为修改了utest.c 触发了ci检查,此报错可以忽略 |
Rbb666
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
utest 原代码中对 case 名字的匹配有问题,因为采用 memcmp 按照 len 的字节匹配,如果输入的 case name 和存在的 case name 存在包含关系,譬如实际 case 名字是 ”gpip_irq“, 输入
utest_run gpio也会匹配成功, 但这不是期望的结果。修改精确匹配的逻辑,直接采用 strcmp。
同时保留原先通配的逻辑,即
utest_run gpio*可以同时匹配 ”gpio“ 和 ”gpio_irq“。拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
你的解决方案是什么 (what is your solution)
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up