Conversation
Signed-off-by: vandoul <vandoul@ticks.cn>
GorrayLi
reviewed
Jun 10, 2025
Contributor
GorrayLi
left a comment
There was a problem hiding this comment.
- rt_slist_pop()中这一处,个人不建议加。理由是,函数的返回值是弹出的节点,即调用者可能会用到它(不一定只用到其data信息),因此尽量不要破坏被移除节点中的原始信息。例如,调用者可通过返回node的next指针是否为空,判断其是否为最后一个节点。
若出于安全考虑,不妨在调用处,根据实际使用场景决定是否对node的next指针赋空。 - rt_slist_remove()中这一处,同意修改。被移除的节点与链表断开连接,避免误用而意外修改链表结构。
Contributor
Author
rt_slist_pop中弹出的是首节点,判断是否为最后一个节点可以通过list头去判断,这样符合的使用逻辑, |
GorrayLi
approved these changes
Jun 10, 2025
Rbb666
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
内核提供的单向链表存在安全风险
你的解决方案是什么 (what is your solution)
将被移除的节点的next指针指向NULL
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up