bsp: artpi2: init project. by StrandingNeko · Pull Request #10364 · RT-Thread/rt-thread

StrandingNeko · 2025-06-04T15:23:51Z

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

BSP:

.config:

action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

已经仔细查看过代码改动的对比 Already check the difference between PR and old code
代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
代码是高质量的 Code in this PR is of high quality
已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

Signed-off-by: stranding <45762837+StrandingNeko@users.noreply.github.com>

StrandingNeko · 2025-06-04T15:25:50Z

emm, I don't know whether rtthread official had plans to release the artpi2 bsp. Just push it here.

Signed-off-by: stranding <45762837+StrandingNeko@users.noreply.github.com>

supperthomas · 2025-06-05T01:46:19Z

📄 bsp/stm32/stm32h7r7-artpi2/figures/board_large.png — [A]
📦 Size: 20.4 MB

📄 bsp/stm32/stm32h7r7-artpi2/figures/create_proj.png — [A]
📦 Size: 388.2 KB

📄 bsp/stm32/stm32h7r7-artpi2/figures/qq_group.png — [A]
📦 Size: 163.6 KB

📄 bsp/stm32/stm32h7r7-artpi2/figures/sdk_manager.png — [A]
📦 Size: 207.7 KB

图片压缩一下。清理一下project下面的多余的文件

supperthomas · 2025-06-05T03:42:53Z

bsp/stm32/libraries/Kconfig


 config SOC_SERIES_STM32H7RS
    bool
+    default y


这里为啥要加y？

😂当时调的时候加的，忘记删了

Signed-off-by: stranding <45762837+StrandingNeko@users.noreply.github.com>

Copilot

Pull Request Overview

This PR initializes the ART-Pi2 BSP project for the STM32H7R7 microcontroller, integrating CubeMX-generated configuration, linker setup, core system code, and RT-Thread application scaffolding.

Added CubeMX CMake configuration and static library targets for HAL drivers
Introduced linker script and system startup files (system init, sysmem, syscalls, interrupts)
Created RT-Thread application example with SCons build scripts and updated documentation

Reviewed Changes

Copilot reviewed 49 out of 49 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
bsp/stm32/stm32h7r7-artpi2/board/CubeMX_Config/Appli/mx-generated.cmake	CubeMX-generated CMake build configuration
bsp/stm32/stm32h7r7-artpi2/board/CubeMX_Config/Appli/STM32H7R7XX.ld	Linker script for FLASH and RAM layout
bsp/stm32/stm32h7r7-artpi2/board/CubeMX_Config/Appli/Core/Src/system_stm32h7rsxx.c	CMSIS system init and clock configuration
bsp/stm32/stm32h7r7-artpi2/board/CubeMX_Config/Appli/Core/Src/sysmem.c	_sbrk heap allocation implementation
bsp/stm32/stm32h7r7-artpi2/board/CubeMX_Config/Appli/Core/Src/syscalls.c	Minimal newlib system call stubs
bsp/stm32/stm32h7r7-artpi2/board/CubeMX_Config/Appli/Core/Src/stm32h7rsxx_it.c	Interrupt service routines
bsp/stm32/stm32h7r7-artpi2/board/CubeMX_Config/Appli/Core/Inc/stm32h7rsxx_it.h	Interrupt handler prototypes
bsp/stm32/stm32h7r7-artpi2/board/CubeMX_Config/Appli/Core/Inc/main.h	Application-wide defines (LED pin) and prototypes
bsp/stm32/stm32h7r7-artpi2/board/CubeMX_Config/Appli/CMakePresets.json	CMake presets for build configurations
bsp/stm32/stm32h7r7-artpi2/board/CubeMX_Config/.mxproject	STM32CubeMX project metadata
bsp/stm32/stm32h7r7-artpi2/board/.ignore_format.yml	Paths excluded from code-format checks
bsp/stm32/stm32h7r7-artpi2/applications/main.c	RT-Thread LED blink example and vector relocation
bsp/stm32/stm32h7r7-artpi2/applications/SConscript	SCons script for application build grouping
bsp/stm32/stm32h7r7-artpi2/SConstruct	Top-level SCons build script for BSP
bsp/stm32/stm32h7r7-artpi2/SConscript	Module SCons script for driver compilation
bsp/stm32/stm32h7r7-artpi2/README_en.md	English documentation and usage instructions
bsp/stm32/stm32h7r7-artpi2/README.md	Chinese documentation
bsp/stm32/stm32h7r7-artpi2/Kconfig	RT-Thread Kconfig integration
bsp/stm32/stm32h7r7-artpi2/EventRecorderStub.scvd	Event recorder stub component metadata
bsp/stm32/stm32h7r7-artpi2/.gitignore	File patterns to ignore in VCS

Comments suppressed due to low confidence (3)

bsp/stm32/stm32h7r7-artpi2/board/CubeMX_Config/Appli/STM32H7R7XX.ld:10

Header comment reports incorrect memory sizes; update to reflect actual FLASH (65536K) and RAM (455K + 64K DTCM).

**                67108864Kbytes FLASH and 0Kbytes RAM

bsp/stm32/stm32h7r7-artpi2/SConscript:11

The define 'STM32H7S7xx' appears to be a typo; it should likely be 'STM32H7R7xx' to match the MCU series.

env.Append(CPPDEFINES = ['STM32H7S7xx'])

bsp/stm32/stm32h7r7-artpi2/README_en.md:38

Document references 'RealThread_STMH7R-ART-Pi.yaml', but the repository file is named 'RealThread_STM32H7R-ART-Pi2.yaml'; update for consistency.

- **RealThread_STMH7R-ART-Pi.yaml**: Describes the hardware information of ART-Pi.

Copilot · 2025-06-05T13:44:03Z

bsp/stm32/stm32h7r7-artpi2/board/CubeMX_Config/Appli/mx-generated.cmake

+    ${CMAKE_SOURCE_DIR}/../Drivers/STM32H7RSxx_HAL_Driver/Src/stm32h7rsxx_ll_usb.c
+)
+
+# Drivers Midllewares


Typo in comment: replace "Midllewares" with "Middlewares".

Suggested change

# Drivers Midllewares

# Drivers Middlewares

Copilot · 2025-06-05T13:44:04Z

bsp/stm32/stm32h7r7-artpi2/SConscript

+list = os.listdir(cwd)
+
+env.Append(CPPDEFINES = ['STM32H7S7xx'])
+
+for d in list:


[nitpick] Variable 'list' shadows the built-in Python type; consider renaming to avoid confusion (e.g., 'entries').

Suggested change

list = os.listdir(cwd)

env.Append(CPPDEFINES = ['STM32H7S7xx'])

for d in list:

entries = os.listdir(cwd)

env.Append(CPPDEFINES = ['STM32H7S7xx'])

for d in entries:

supperthomas · 2025-06-06T06:43:31Z

BPS加一下

supperthomas

请添加自己需要的文件，编译不到的多余文件，自动生成的文件，都删除

supperthomas · 2025-06-06T06:45:06Z

bsp/stm32/stm32h7r7-artpi2/board/CubeMX_Config/Appli/CMakePresets.json

@@ -0,0 +1,60 @@
+{
+    "version": 3,
+    "configurePresets": [


supperthomas · 2025-06-06T06:45:43Z

bsp/stm32/stm32h7r7-artpi2/EventRecorderStub.scvd

+
+<component_viewer schemaVersion="0.1" xmlns:xs="http://www.w3.org/2001/XMLSchema-instance" xs:noNamespaceSchemaLocation="Component_Viewer.xsd">
+
+<component name="EventRecorderStub" version="1.0.0"/>       <!--name and version of the component-->


supperthomas · 2025-06-06T06:46:52Z

bsp/stm32/stm32h7r7-artpi2/board/CubeMX_Config/Appli/Core/Src/stm32h7rsxx_it.c

+
+  /* USER CODE END SysTick_IRQn 0 */
+  HAL_IncTick();
+  /* USER CODE BEGIN SysTick_IRQn 1 */


supperthomas · 2025-06-06T06:46:59Z

bsp/stm32/stm32h7r7-artpi2/board/CubeMX_Config/Appli/Core/Src/sysmem.c

+ */
+
+/* Includes */
+#include <errno.h>


supperthomas · 2025-06-06T06:47:20Z

bsp/stm32/stm32h7r7-artpi2/board/CubeMX_Config/Appli/Core/Src/system_stm32h7rsxx.c

+  *           constant and the selected clock source:
+  *
+  *           - If SYSCLK source is HSI, SystemCoreClock will contain the HSI_VALUE(*)
+  *


supperthomas · 2025-06-06T06:47:28Z

bsp/stm32/stm32h7r7-artpi2/board/CubeMX_Config/Appli/STM32H7R7XX.ld

+**                Set memory bank area and size if external memory is used.
+**
+**  Target      : STMicroelectronics STM32
+**


supperthomas · 2025-06-06T06:47:38Z

bsp/stm32/stm32h7r7-artpi2/board/CubeMX_Config/Appli/STM32H7R7XX.ld

+
+    . = ALIGN(4);
+    _ebss = .;         /* define a global symbol at bss end */
+    __bss_end__ = _ebss;


supperthomas · 2025-06-06T06:47:45Z

bsp/stm32/stm32h7r7-artpi2/board/CubeMX_Config/gcc-arm-none-eabi.cmake

+
+set(CMAKE_EXECUTABLE_SUFFIX_ASM     ".elf")
+set(CMAKE_EXECUTABLE_SUFFIX_C       ".elf")
+set(CMAKE_EXECUTABLE_SUFFIX_CXX     ".elf")


supperthomas · 2025-06-06T06:47:52Z

bsp/stm32/stm32h7r7-artpi2/board/CubeMX_Config/mx-generated.cmake

+    message("   Build context: " Appli)
+    ExternalProject_Add(CubeMX_Config_Appli
+        BINARY_DIR                  ${CMAKE_SOURCE_DIR}/Appli/build
+        SOURCE_DIR                  ${PROJECT_SOURCE_DIR}/Appli


Signed-off-by: stranding <45762837+StrandingNeko@users.noreply.github.com>

github-actions · 2025-06-06T13:38:57Z

📌 Code Review Assignment

🏷️ Tag: workflow

Path: .github
Reviewers: supperthomas Rbb666 kurisaW

Changed Files (Click to expand)

.github/ALL_BSP_COMPILE.json

📊 Current Review Status (Last Updated: 2025-06-08 01:11 UTC)

⌛ Rbb666 Pending Review
⌛ kurisaW Pending Review
⌛ supperthomas Pending Review

📝 Review Instructions

维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
Maintainers can refresh the review status by clicking here: 🔄 Refresh Status
确认审核通过后评论 LGTM/lgtm
Comment LGTM/lgtm after confirming approval
PR合并前需至少一位维护者确认
PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

Signed-off-by: stranding <45762837+StrandingNeko@users.noreply.github.com>

supperthomas · 2025-06-07T01:32:05Z

bsp/stm32/stm32h7r7-artpi2/board/CubeMX_Config/Appli/Core/Inc/stm32h7rsxx_it.h

+/**
+  ******************************************************************************
+  * @file    stm32h7rsxx_it.h
+  * @brief   This file contains the headers of the interrupt handlers.


supperthomas · 2025-06-07T01:32:21Z

bsp/stm32/stm32h7r7-artpi2/board/CubeMX_Config/Appli/Core/Inc/main.h

+/* Private includes ----------------------------------------------------------*/
+/* USER CODE BEGIN Includes */
+
+/* USER CODE END Includes */


supperthomas · 2025-06-07T01:33:08Z

bsp/stm32/stm32h7r7-artpi2/board/CubeMX_Config/Appli/Core/Src/main.c

@@ -0,0 +1,1097 @@
+/* USER CODE BEGIN Header */
+/**
+  ******************************************************************************


supperthomas · 2025-06-07T01:33:21Z

bsp/stm32/stm32h7r7-artpi2/board/CubeMX_Config/Appli/Core/Startup/startup_stm32h7r7xx.s

+  * @brief     STM32H7R7xx Devices vector table for GCC toolchain.
+  *            This module performs:
+  *                - Set the initial SP
+  *                - Set the initial PC == Reset_Handler,


Signed-off-by: stranding <45762837+StrandingNeko@users.noreply.github.com>

Rbb666 · 2025-06-07T06:41:13Z

.github/ALL_BSP_COMPILE.json

        "stm32/stm32h750-weact-ministm32h7xx",
        "stm32/stm32h750-fk750m1-vbt6",
        "stm32/stm32h7s7-st-disco",
+		"stm32/stm32h7r7-artpi2",


请检查下这块的缩进

Rbb666 · 2025-06-07T06:42:39Z

bsp/stm32/stm32h7r7-artpi2/rtconfig.py

+
+    POST_ACTION = 'fromelf --bin $TARGET --output rtthread.bin \nfromelf -z $TARGET'
+
+elif PLATFORM == 'iccarm':


此工程如果没有验证的工具链比如（IAR）的，可以删除，只保留验证过的

Signed-off-by: stranding <45762837+StrandingNeko@users.noreply.github.com>

bsp: artpi2: init project.

eea7fb9

Signed-off-by: stranding <45762837+StrandingNeko@users.noreply.github.com>

github-actions bot added BSP: STM32 BSP related with ST/STM32 BSP labels Jun 4, 2025

bsp: artpi2: clean linkers.

47255b3

Signed-off-by: stranding <45762837+StrandingNeko@users.noreply.github.com>

supperthomas requested changes Jun 5, 2025

View reviewed changes

supperthomas requested a review from Copilot June 5, 2025 08:46

supperthomas added the BSP: new bsp board New added bsp, need sync action label Jun 5, 2025

This comment was marked as outdated.

Sign in to view

StrandingNeko added 2 commits June 5, 2025 21:17

bsp: artpi2: fix an default error.

5db4b21

Signed-off-by: stranding <45762837+StrandingNeko@users.noreply.github.com>

bsp: artpi2: fix image size.

af08312

Signed-off-by: stranding <45762837+StrandingNeko@users.noreply.github.com>

StrandingNeko requested review from Copilot and supperthomas June 5, 2025 13:41

Copilot AI reviewed Jun 5, 2025

View reviewed changes

supperthomas requested changes Jun 6, 2025

View reviewed changes

bsp: artpi2: remove unused files.

53f9986

Signed-off-by: stranding <45762837+StrandingNeko@users.noreply.github.com>

github-actions bot added the action github action yml imporve label Jun 6, 2025

StrandingNeko requested a review from supperthomas June 6, 2025 13:50

bsp: artpi2: clean .gitignore.

a62438e

Signed-off-by: stranding <45762837+StrandingNeko@users.noreply.github.com>

supperthomas requested changes Jun 7, 2025

View reviewed changes

supperthomas mentioned this pull request Jun 7, 2025

stm32h7r7-atk bsp #10363

Closed

10 tasks

bsp: artpi2: remove unused files.(2)

e11d348

Signed-off-by: stranding <45762837+StrandingNeko@users.noreply.github.com>

StrandingNeko force-pushed the master branch from 223c9ef to e11d348 Compare June 7, 2025 02:11

Rbb666 reviewed Jun 7, 2025

View reviewed changes

StrandingNeko added 3 commits June 7, 2025 20:27

bsp: artpi2: repair tab.

c0c4785

Signed-off-by: stranding <45762837+StrandingNeko@users.noreply.github.com>

bsp: artpi2: remove iar project config.

1172726

Signed-off-by: stranding <45762837+StrandingNeko@users.noreply.github.com>

bsp: artpi2: add sd card filesystem support.

72eefc4

Signed-off-by: stranding <45762837+StrandingNeko@users.noreply.github.com>

supperthomas approved these changes Jun 8, 2025

View reviewed changes

Rbb666 approved these changes Jun 8, 2025

View reviewed changes

Rbb666 merged commit 12ac742 into RT-Thread:master Jun 8, 2025
59 checks passed


		<component_viewer schemaVersion="0.1" xmlns:xs="http://www.w3.org/2001/XMLSchema-instance" xs:noNamespaceSchemaLocation="Component_Viewer.xsd">

		<component name="EventRecorderStub" version="1.0.0"/> <!--name and version of the component-->


		POST_ACTION = 'fromelf --bin $TARGET --output rtthread.bin \nfromelf -z $TARGET'

		elif PLATFORM == 'iccarm':

Conversation

StrandingNeko commented Jun 4, 2025

拉取/合并请求描述：(PR description)

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

当前拉取/合并请求的状态 Intent for your PR

代码质量 Code Quality：

Uh oh!

StrandingNeko commented Jun 4, 2025

Uh oh!

supperthomas commented Jun 5, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jun 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 5, 2025

Choose a reason for hiding this comment

Uh oh!

supperthomas commented Jun 6, 2025

Uh oh!

supperthomas left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📌 Code Review Assignment

🏷️ Tag: workflow

📊 Current Review Status (Last Updated: 2025-06-08 01:11 UTC)

📝 Review Instructions

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

github-actions bot commented Jun 6, 2025 •

edited

Loading