修复任务丢失，性能优化 by htl5241 · Pull Request #10355 · RT-Thread/rt-thread

htl5241 · 2025-06-03T00:49:26Z

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

BSP:

.config:

action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

已经仔细查看过代码改动的对比 Already check the difference between PR and old code
代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
代码是高质量的 Code in this PR is of high quality
已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

htl5241 · 2025-06-03T01:11:02Z

test.zip
任务丢失测试代码

htl5241 · 2025-06-03T01:12:07Z

这个代码因为修改幅度比较大，所以整个文件做了格式化操作。还有已经过了测试，稳定性没问题。

htl5241 · 2025-06-03T01:14:28Z

因为调度代码被执行的比较频繁，所以做了性能优化，cortex-m4在100mhz 下性能最低提升15%

htl5241 · 2025-06-03T01:16:32Z

你们可以先跑这个文件的稳定性，完全没问题在拉入。我已经测试了10多天了。

supperthomas · 2025-06-03T01:20:37Z

不同的PR，可以用不同的分支名称，不需要放到一起。
新的PR开始之前，先基于origin/master上进行创建修改分支。

Rbb666 · 2025-06-03T10:07:49Z

CI有编译报错，请先解决下：

代码可以用：formatting 脚本格式化下

Guozhanxin · 2025-06-03T10:22:07Z

src/scheduler_up.c

-    rt_ubase_t highest_ready_priority;

-    to_thread = _scheduler_get_highest_priority_thread(&highest_ready_priority);
+    _scheduler_update_highest_priority();


这里为什么需要先更新最高优先级的任务？什么情况下，需要手动更新这个？

htl5241 · 2025-06-03T14:55:51Z

CI有编译报错，请先解决下：

代码可以用：formatting 脚本格式化下

ok

htl5241 · 2025-06-03T15:24:10Z

CI有编译报错，请先解决下：

代码可以用：formatting 脚本格式化下

我测试了famatting 和clang-format效果一样

This reverts commit 2774d65.

github-actions · 2025-06-10T09:34:54Z

📌 Code Review Assignment

🏷️ Tag: kernel

Path: src
Reviewers: GorrayLi

Changed Files (Click to expand)

src/scheduler_up.c

📊 Current Review Status (Last Updated: 2025-06-11 05:07 UTC)

⌛ GorrayLi Pending Review

📝 Review Instructions

维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
Maintainers can refresh the review status by clicking here: 🔄 Refresh Status
确认审核通过后评论 LGTM/lgtm
Comment LGTM/lgtm after confirming approval
PR合并前需至少一位维护者确认
PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

GorrayLi · 2025-06-10T10:44:26Z

建议先描述一下本次PR要解决什么问题，以及解决方案是什么？以便reviewer能更容易理解修改代码的意图。@htl5241

htl5241 · 2025-06-10T10:48:38Z

建议先描述一下本次PR要解决什么问题，以及解决方案是什么？以便reviewer能更容易理解修改代码的意图。@htl5241

不停的新建任务，退出任务，就会丢失任务。还有就是优化性能，这次pr性能提升很多。

htl5241 · 2025-06-10T10:51:26Z

建议先描述一下本次PR要解决什么问题，以及解决方案是什么？以便reviewer能更容易理解修改代码的意图。@htl5241

还有就是你看这个pr都描述了，还有其他维护人员留了两行字就不见了。

GorrayLi · 2025-06-10T11:58:17Z

src/scheduler_up.c

 #include <rtdbg.h>

-rt_list_t rt_thread_priority_table[RT_THREAD_PRIORITY_MAX];
+rt_list_t   rt_thread_priority_table[RT_THREAD_PRIORITY_MAX];


多余空格请去掉。

GorrayLi · 2025-06-10T11:58:52Z

src/scheduler_up.c

 extern volatile rt_atomic_t rt_interrupt_nest;
-static rt_int16_t rt_scheduler_lock_nest;
-rt_uint8_t rt_current_priority;
+static rt_int16_t           rt_scheduler_lock_nest;


同上，去掉多余空格。

GorrayLi · 2025-06-10T12:00:50Z

src/scheduler_up.c

 {
 #if RT_THREAD_PRIORITY_MAX > 32
-    RT_SCHED_PRIV(thread).number = RT_SCHED_PRIV(thread).current_priority >> 3;            /* 5bit */
+    RT_SCHED_PRIV(thread).number      = RT_SCHED_PRIV(thread).current_priority >> 3; /* 5bit */


同上，去掉多余空格。

GorrayLi · 2025-06-10T12:02:07Z

src/scheduler_up.c

-    RT_SCHED_PRIV(thread).high_mask = 1L << (RT_SCHED_PRIV(thread).current_priority & 0x07);  /* 3bit */
+    RT_SCHED_PRIV(thread).high_mask =
+        1L
+        << (RT_SCHED_PRIV(thread).current_priority & 0x07); /* 3bit */


这行代码不必要分成三行。

GorrayLi · 2025-06-10T12:02:33Z

src/scheduler_up.c

    RT_SCHED_PRIV(thread).number_mask = 0;
 #if RT_THREAD_PRIORITY_MAX > 32
-    RT_SCHED_PRIV(thread).number = 0;
+    RT_SCHED_PRIV(thread).number    = 0;


同上，空格问题。

GorrayLi · 2025-06-10T12:02:45Z

src/scheduler_up.c


    /* tick init */
-    RT_SCHED_PRIV(thread).init_tick = tick;
+    RT_SCHED_PRIV(thread).init_tick      = tick;


同上，空格问题。

GorrayLi · 2025-06-10T12:03:24Z

src/scheduler_up.c

        if (critical_level != rt_scheduler_lock_nest)
        {
-            int dummy = 1;
+            int dummy                = 1;


同上，不必要的空格。

配置文件格式化

htl5241 · 2025-06-10T13:40:14Z

clang-format.zip
这个是我从kernel 复制过来的，稍微微调了一下参数。

GorrayLi · 2025-06-11T01:51:17Z

CI有报错，请修复。

GorrayLi · 2025-06-11T02:06:56Z

建议先描述一下本次PR要解决什么问题，以及解决方案是什么？以便reviewer能更容易理解修改代码的意图。@htl5241

不停的新建任务，退出任务，就会丢失任务。还有就是优化性能，这次pr性能提升很多。

“丢失任务”的具体现象是什么？是删除后（有残留）无法再创建?
“性能提升”具体指的是哪方面的性能提升？

GorrayLi · 2025-06-11T03:42:57Z

src/scheduler_up.c

 {
-    if (rt_thread_self())
-    {
+    if (rt_thread_self()) {


根据rt_thread的编码规范，花括号应独占一行。这里需要回退。

GorrayLi · 2025-06-11T03:44:27Z

src/scheduler_up.c


-    for (offset = 0; offset < RT_THREAD_PRIORITY_MAX; offset ++)
-    {
+    for (offset = 0; offset < RT_THREAD_PRIORITY_MAX; ++offset) {


同上，花括号独占一行。

GorrayLi · 2025-06-11T03:48:25Z

src/scheduler_up.c

-                {
-                    need_insert_from_thread = 1;
-                }
+    if (rt_scheduler_lock_nest == 0 && rt_thread_ready_priority_group) {


花括号独占一行。

GorrayLi · 2025-06-11T03:48:34Z

src/scheduler_up.c

+        need_insert_from_thread = RT_FALSE;
+        curr_thread = rt_thread_self();
+
+        if ((RT_SCHED_CTX(curr_thread).stat & RT_THREAD_STAT_MASK) == RT_THREAD_RUNNING) {


花括号独占一行，代码中其它同样的情况请一并修改。

htl5241 · 2025-06-11T04:54:06Z

建议先描述一下本次PR要解决什么问题，以及解决方案是什么？以便reviewer能更容易理解修改代码的意图。@htl5241

不停的新建任务，退出任务，就会丢失任务。还有就是优化性能，这次pr性能提升很多。
1. “丢失任务”的具体现象是什么？是删除后（有残留）无法再创建?

2. “性能提升”具体指的是哪方面的性能提升？

你们如果不接收我也没必要和你们来回扯皮，给你们复现的程序自己去测试。

htl5241 · 2025-06-11T05:21:31Z

给复现程序了，自己不去复现，性能也不去做测试，只卡你能不能融入主线。还有就是项目这样那样限制你格式，那就提供能用的clang-format。所以说国内的开源项目特抽象。

htl5241 · 2025-06-11T05:25:18Z

scheduler_up.zip
这个是修改后的文件，性能提升不提升，自己去做测试。

htl5241 added 2 commits June 1, 2025 20:43

linux tulpe报错修复，llvm-arm编译器报错

2774d65

修复任务丢失，性能优化

2310781

github-actions bot added Kernel PR has src relate code tools labels Jun 3, 2025

Guozhanxin reviewed Jun 3, 2025

View reviewed changes

替换static inline为rt_inline

0d86ecf

htl5241 added 2 commits June 3, 2025 23:16

更新

200f748

更新

90dff70

Revert "linux tulpe报错修复，llvm-arm编译器报错"

b92f8a9

This reverts commit 2774d65.

htl5241 requested a review from Guozhanxin June 5, 2025 12:04

同步注释

cad855b

冲突同步

b8b258a

htl5241 closed this Jun 10, 2025

htl5241 reopened this Jun 10, 2025

GorrayLi reviewed Jun 10, 2025

View reviewed changes

htl5241 added 5 commits June 10, 2025 20:58

用linux-kernel clang-format

bbddbc3

配置文件格式化

又重新格式化

052ed70

重新格式化

5bf1ffb

格式化

ffdb2ca

手动微调

b0fb809

htl5241 requested a review from GorrayLi June 10, 2025 13:45

GorrayLi reviewed Jun 11, 2025

View reviewed changes

htl5241 added 2 commits June 11, 2025 13:02

在格式化

97d49e9

在格式化

52cab87

htl5241 closed this Jun 11, 2025

Conversation

htl5241 commented Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

拉取/合并请求描述：(PR description)

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

当前拉取/合并请求的状态 Intent for your PR

代码质量 Code Quality：

Uh oh!

htl5241 commented Jun 3, 2025

Uh oh!

htl5241 commented Jun 3, 2025

Uh oh!

htl5241 commented Jun 3, 2025

Uh oh!

htl5241 commented Jun 3, 2025

Uh oh!

supperthomas commented Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Rbb666 commented Jun 3, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

htl5241 commented Jun 3, 2025

Uh oh!

htl5241 commented Jun 3, 2025

Uh oh!

github-actions bot commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📌 Code Review Assignment

🏷️ Tag: kernel

📊 Current Review Status (Last Updated: 2025-06-11 05:07 UTC)

📝 Review Instructions

Uh oh!

GorrayLi commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

htl5241 commented Jun 10, 2025

Uh oh!

htl5241 commented Jun 10, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

htl5241 commented Jun 10, 2025

Uh oh!

GorrayLi commented Jun 11, 2025

Uh oh!

GorrayLi commented Jun 11, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

GorrayLi Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

htl5241 commented Jun 11, 2025

Uh oh!

htl5241 commented Jun 11, 2025

Uh oh!

htl5241 commented Jun 11, 2025

Uh oh!

Reviewers

htl5241 commented Jun 3, 2025 •

edited

Loading

supperthomas commented Jun 3, 2025 •

edited

Loading

github-actions bot commented Jun 10, 2025 •

edited

Loading

GorrayLi commented Jun 10, 2025 •

edited

Loading

GorrayLi Jun 11, 2025 •

edited

Loading