[Fix] <components>:finsh/shell.c F: char rt_hw_console_getchar(void)#10345
Merged
kurisaW merged 1 commit intoRT-Thread:masterfrom Jul 20, 2025
Merged
[Fix] <components>:finsh/shell.c F: char rt_hw_console_getchar(void)#10345kurisaW merged 1 commit intoRT-Thread:masterfrom
kurisaW merged 1 commit intoRT-Thread:masterfrom
Conversation
Member
|
或者这部分应该调整成 |
Contributor
Author
|
我觉得可以解决问题 我这两天 改完测一下吧 |
Contributor
Author
|
signed char同样可以 @BernardXiong |
Member
感觉也不用,可以试着提个pr看下效果 |
Contributor
Author
|
ok 那我这个pr先留着? |
Member
如果是 |
When using char rt_hw_console_getchar(void), some compilers may default to returning 255 instead of the expected -1, causing the condition if(ch < 0) at F: shell.c L:519 to fail and enter an erroneous loop. Solution: Use the signed char type return value as rt_hw_console_getchar Signed-off-by: Yucai Liu <1486344514@qq.com>
f7d1195 to
2af2fae
Compare
Contributor
Author
|
好的 我已改成signed char作为 rt_hw_console_getchar的返回值 |
BernardXiong
approved these changes
Jul 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using char rt_hw_console_getchar(void),
some compilers may default to returning 255 instead of the expected -1, causing the condition if(ch < 0) at F: shell.c L:519 to fail and enter an erroneous loop.
Solution: Use the same int type return value as finsh_getchar
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
你的解决方案是什么 (what is your solution)
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up